Add Now() method to ProjectionCompactScope.
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalloc
force-pushed
the
141-compact-scope-now
branch
from
77c4e90
to
5ebbe62
Compare
|
Just pushed a slight rewording. |
danilvpetrov
approved these changes
Feb 18, 2021
koden-km
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
This PR introduces a
Now()method to theProjectionCompactScopeinterface.Why make this change?
This allows compaction logic to expire old data even under testkit and/or its memory engine where the engine's notion of time is not necessarily the real wall clock time.
Is there anything you are unsure about?
We are unsure if this method may be needed on other scopes as well, but have opted only to implement it here for now as we have a concrete use case for compacting projections.
What issues does this relate to?
Fixes #141