Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DokanOperations and mirror rename fileName #290

Open
TrabacchinLuigi opened this issue Mar 4, 2022 · 5 comments
Open

DokanOperations and mirror rename fileName #290

TrabacchinLuigi opened this issue Mar 4, 2022 · 5 comments

Comments

@TrabacchinLuigi
Copy link
Contributor

TrabacchinLuigi commented Mar 4, 2022

The variable named fileName in all the methods exposed in IDokanOperations should have been path, fileName is as confusing as it could be.

@Liryna
Copy link
Member

Liryna commented Mar 4, 2022

This comes from the Kernel where all variables holding the path of files are named FileName

@TrabacchinLuigi
Copy link
Contributor Author

i can understand the choice of keeping that way, but i still advocate for changing it, this library is for .net where a path and a filename have a different meaning, if you don't, no hard feelings 🤣

@Liryna
Copy link
Member

Liryna commented Mar 4, 2022

That's a valid reason! File.Open is taking a path https://docs.microsoft.com/en-us/dotnet/api/system.io.file.open?view=net-6.0
but the sample is using filename https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream?view=net-6.0
So I am open for debate and pull request 😆

@TrabacchinLuigi
Copy link
Contributor Author

so in our implementation, we renamed all the variables coming from dokan.net named fileName to kernelPath, since we will have other paths involved, i think this is a reasonable and less confusing name.
I'll be very happy to work on this if requested.

@Liryna
Copy link
Member

Liryna commented Mar 5, 2022

I am less a fan of kernelpath as it could be taken as another Microsoft format and it is not DotNet style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants