Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opener does not exit #35

Open
openhoat opened this issue Aug 17, 2022 · 0 comments · May be fixed by #36
Open

opener does not exit #35

openhoat opened this issue Aug 17, 2022 · 0 comments · May be fixed by #36

Comments

@openhoat
Copy link

openhoat commented Aug 17, 2022 •
edited

Here's a strange issue encountered using opener:

How to reproduce:

  1. Start your favourite browser
  2. Run npx opener http://google.com in a terminal
  3. The browser should point to the requested page and the command should exit
  4. Then close the browser and repeat (2)
    => The browser show the page, but the command does not exit

opener command successfully exits when the browser is already started (and usually this is not my case), I suppose it should exit in all situations.

Tested with Chrome on Linux (Fedora)
@openhoat openhoat linked a pull request Aug 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to exit properly openhoat/opener
1 participant
@openhoat