Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package JS libraries in nyaplot and don't rely on external CDN #77

Open
v0dro opened this issue Jun 6, 2016 · 3 comments
Open

Package JS libraries in nyaplot and don't rely on external CDN #77

v0dro opened this issue Jun 6, 2016 · 3 comments

Comments

@v0dro
Copy link

v0dro commented Jun 6, 2016

This elagans link: (https://cdn.rawgit.com/domitry/d3-downloadable/master/d3-downloadable","THREE":"https://cdnjs.cloudflare.com/ajax/libs/three.js/r66/three.min) is not being downloaded via the CDN.

I think including it with the repo would solve the problem.

@mrkn
Copy link
Contributor

mrkn commented Jun 12, 2016

Inlining JS file can fix this issue, I think.

I want to introduce a feature like load_notebook in bokeh.
It can allow us to specify where assets are loaded from.
At least I want to select inline or cdn at nyaplot initialization time, and I prefer the default is inline (bokeh's default is also inline).

But it needs to change nyaplot initialization protocol.
While we just need to do require 'nyaplot'currently, introducing bokeh feature requires explicit initialization.

I think this modification is acceptable.
How do you think about it?

@v0dro
Copy link
Author

v0dro commented Jun 12, 2016

Sure. We can have some reliable default setting that works most of the time and also allow flexibility to choose sources with the load_notebook initialization.

@mrkn
Copy link
Contributor

mrkn commented Jun 22, 2016

I've submit a pull-request #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants