Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name: "krautoload" vs "donquixote/krautoload" vs "krautoload/krautoload". #12

Open
donquixote opened this issue Jul 15, 2013 · 4 comments

Comments

@donquixote
Copy link
Owner

I am undecided about the project name in composer.json.
"krautoload" or "donquixote/krautoload" or "krautoload/krautoload" or sth else.

I personally think that a one-level name is more useful for a standalone package - both for the name in composer.json, and for the namespace.

However, conventions set forth by Composer probably want me to add a vendor namespace.

E.g., Assetic has "kriswallsmith" as its vendor namespace. If you add kriswallsmith/assetic as a dependency, Assetic will go into a subdirectory vendor/kriswallsmith/assetic.

I personally find that undesirable, I would rather see "assetic" and "krautoload" as top-level directories, and not the author names.

@donquixote
Copy link
Owner Author

This has led to two commits and releases (maybe I was too fast there):
2d9d876 switching to "krautoload".
3fe8412 switching back to "donquixote/krautoload".

@donquixote
Copy link
Owner Author

See also this comment about vendor namespace in PSR-0,
#10 (comment)

Notes:

  • It adds one meaningless directory nesting level (on the project that wants to include Krautoload via composer).
  • It introduces an author name into the game, which may distract more than it helps.
  • If you download a fork, it will go into a different directory under vendor/. (which may be good or bad)

The arguments are not exactly the same as for the PSR-0 namespaces.

@donquixote donquixote mentioned this issue Jul 15, 2013
@RobLoach
Copy link

What's wrong with donquixote/krautoload? donquixote is the vendor, krautoload is the project. If you install another project by you, it would also live in the donquixote vendor path. This is the desired affect because if someone forked your project and wanted to run their fork, they could. This mimics the way github is designed, vendor/packagename just avoids project name conflicts.

If you don't want to use Composer, you don't have to, you could just register the namespaces/class yourself and install krautoload wherever you want.

Drupal.org is a good example of what not having vendor/package can do. Everyone is competing over module names haha.

@donquixote
Copy link
Owner Author

What's wrong with donquixote/krautoload

It will result in core/vendor/donquixote/krautoload in Drupal 8, and somehow I don't like that.. It is like those days when I installed a game on Windows, and it would add itself in the start menu under the company name, instead of the name of the game.

But I am willing to go with the flow, and make it donquixote/krautoload.
(I am going to be more stubborn when talking about PSR-0 namespaces..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants