Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Liquid 5.0.0 language features #438

Open
robin-parker opened this issue Jun 18, 2021 · 3 comments
Open

Implement Liquid 5.0.0 language features #438

robin-parker opened this issue Jun 18, 2021 · 3 comments
Labels

Comments

@robin-parker
Copy link
Contributor

robin-parker commented Jun 18, 2021

Dotliquid version

2.1.457

Expected behavior

Implement Liquid 5.0.0 language features, including:

Actual behavior

Not yet implemented.

Steps to reproduce the Problem (you can add files)

Not applicable

@microalps
Copy link
Contributor

microalps commented Jun 29, 2021

Should this be a placeholder for all 5.0 features missing? I mentioned a few new tags in the wiki.

Also, the entire concept of named parameters in liquid filters doesn't exist AFAIK, so we need to add the infrastructure for it. Is this the only such case?

@robin-parker
Copy link
Contributor Author

Makes sense to have a placeholder for 5.0.0 for tracking the feature gaps, the Liquid change history categorizes Shopify/liquid#1144 as a fix, rather than a new feature.

allow_false: is the only case of a named parameter that I could find.

@robin-parker robin-parker changed the title Default filter allow_false: named parameter not implemented Implement Liquid 5.0.0 language features Jun 30, 2021
@MarioMajcicaAtABNAMRO
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants