Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Check OS version runtime #852

Closed
AskBojesen opened this issue May 14, 2024 · 5 comments · Fixed by #853
Closed

Windows: Check OS version runtime #852

AskBojesen opened this issue May 14, 2024 · 5 comments · Fixed by #853

Comments

@AskBojesen
Copy link
Contributor

AskBojesen commented May 14, 2024

Windows: Check OS version number.

BLE version = 3.1.0-rc1

Currently a runtime on the Windows client needs > 22000
Eg. to call this: https://learn.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothlepreferredconnectionparameters
Unfortunately Windows allow executing code linked to > 22000 - only at runtime calling new functionality causes error.

  1. Run on a Windows 10
  2. Connect to an instrument

Expected behavior

Connected without errors

Actual behavior

Cannot connect

@smsissuechecker
Copy link

Hi @AskBojesen,

I'm the friendly issue checker.
It seems like (75.00 %) you haven't used our issue template 😢 I think it is very frustrating for the repository owners, if you ignore them.

If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.

Thanks!

@janusw
Copy link
Member

janusw commented May 15, 2024

I think this is a regression, which has been introduced in 3.1.0-beta.2 via #801. It should be fixed before we release the final version 3.1.0.

@janusw
Copy link
Member

janusw commented May 15, 2024

See also the discussion in #849 ...

@AskBojesen
Copy link
Contributor Author

Ok, I will make a draft PR today to fix this

@AskBojesen
Copy link
Contributor Author

PR: #853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants