Fixed refcounting bug in new string implementation

doxygen · Oct 21, 2014 · a9dcbfe · a9dcbfe
1 parent 9323ae4
commit a9dcbfe
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 803 deletions.
diff --git a/qtools/qcstring.h b/qtools/qcstring.h
@@ -498,19 +498,22 @@ class QCString
         }
         StringRep &operator=(const StringRep &s)
         {
-          if (!u.s.isShort)
-          {
-            u.l.d->dispose();
-          }
-          if (s.u.s.isShort) // copy by value
-          {
-            u.s = s.u.s;
-          }
-          else // copy by reference
+          if (&s!=this)
           {
-            u.l.isShort=FALSE;
-            u.l.d = s.u.l.d;
-            u.l.d->refCount++;
+            if (!u.s.isShort)
+            {
+              u.l.d->dispose();
+            }
+            if (s.u.s.isShort) // copy by value
+            {
+              u.s = s.u.s;
+            }
+            else // copy by reference
+            {
+              u.l.isShort=FALSE;
+              u.l.d = s.u.l.d;
+              u.l.d->refCount++;
+            }
           }
           return *this;
         }