Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toleration to run on all nodes (even tainted ones) #6

Open
dshackith opened this issue Apr 8, 2021 · 5 comments · May be fixed by #11
Open

Add toleration to run on all nodes (even tainted ones) #6

dshackith opened this issue Apr 8, 2021 · 5 comments · May be fixed by #11

Comments

@dshackith
Copy link

We segment our node groups with taints, and by default missing-container-metrics does not install on any nodes with taints. Adding the toleration

tolerations:
        - operator: Exists

Would ensure the daemonset is running on all nodes. Alternatively, allowing for setting tolerations in the Helm chart would give deployers the ability to manage this.

@draganm
Copy link
Owner

draganm commented Apr 29, 2021

thank you for the tip! Will release soon(ish) a helm chart version that will allow to set tolerations.

@anderson4u2
Copy link

Hi, I'm potentially interested in contributing to the helm chart, what's the repo for contributing to it? Found the helm chart but that links to this repo that doesn't have a helm chart. Thanks!

@wiseelf
Copy link

wiseelf commented Jul 5, 2021

Please add tolerations support to the helm chart.

@dshackith
Copy link
Author

Created #9 for to add tolerations for all taints

@dshackith
Copy link
Author

dshackith commented Jul 13, 2021

Hi, I'm potentially interested in contributing to the helm chart, what's the repo for contributing to it? Found the helm chart but that links to this repo that doesn't have a helm chart. Thanks!

@anderson4u2 The chart is in the docs subdir: https://github.com/draganm/missing-container-metrics/tree/master/docs/missing-container-metrics

@kenanelgaouny kenanelgaouny linked a pull request Sep 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants