Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for rbenv #45

Merged
merged 1 commit into from Jun 22, 2012
Merged

add support for rbenv #45

merged 1 commit into from Jun 22, 2012

Conversation

chrislerum
Copy link
Contributor

Just a harmless little 'source if it exists' line for rbenv users.

@drewdeponte
Copy link
Owner

Thanks for the pull request @chrislerum. As soon as I can get around to testing it, assuming that all works well and it doesn't effect RVM usage I will merge it in. Based on reading the diff I don't foresee it causing any problems but I want to test it for sure before I merge it into master and it gets distributed to the world.

Thanks Again

@@ -9,6 +9,13 @@
# to assume that those two things exist in the provided
# project path.

function load_rbenv(){
if [ -d $HOME/.rbenv ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be if [ -d "$HOME/.rbenv" ]; then to support people with spaces in their $HOME.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@jpfuentes2
Copy link

+1

drewdeponte added a commit that referenced this pull request Jun 22, 2012
@drewdeponte drewdeponte merged commit 81884f8 into drewdeponte:master Jun 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants