fix(anchorScroll): find offset of nested elements correctly

Closes #618
ionic-team · Feb 17, 2014 · 17cc040 · 17cc040
1 parent 9bc928f
commit 17cc040
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 49 deletions.
diff --git a/js/utils/dom.js b/js/utils/dom.js
@@ -17,16 +17,10 @@
      * until we are at the direct child of parentEl
      * use-case: find scroll offset of any element within a scroll container
      */
-    getPositionInParent: function(el, parentEl) {
-      var left = 0, top = 0;
-      while (el && el !== parentEl) {
-        left += el.offsetLeft;
-        top += el.offsetTop;
-        el = el.parentNode;
-      }
+    getPositionInParent: function(el) {
       return {
-        left: left,
-        top: top
+        left: el.offsetLeft,
+        top: el.offsetTop
       };
     },
 

diff --git a/test/js/utils/dom.js b/test/js/utils/dom.js
diff --git a/test/js/utils/dom.unit.js b/test/js/utils/dom.unit.js
@@ -0,0 +1,10 @@
+
+describe('js/utils/dom', function() {
+
+  describe('getPositionInParent', function() {
+    it('should return el.{offsetLeft,offsetTop}', function() {
+      var el = { offsetLeft: 3, offsetTop: 4 };
+      expect(ionic.DomUtil.getPositionInParent(el)).toEqual({ left: 3, top: 4 });
+    });
+  });
+});