Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position change when toggling side menus #557

Closed
zonason opened this issue Feb 7, 2014 · 6 comments
Closed

Scroll position change when toggling side menus #557

zonason opened this issue Feb 7, 2014 · 6 comments
Milestone

Comments

@zonason
Copy link

zonason commented Feb 7, 2014

In reference to this forum post - http://forum.ionicframework.com/t/scroll-position-on-back/291/21?u=ethan

Calling $scope.sideMenuController.toggleLeft(); causes the content pain to scroll to the top when toggling closed.

@ajoslin ajoslin added this to the 0.9.24 milestone Feb 7, 2014
@ajoslin ajoslin self-assigned this Feb 7, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Feb 7, 2014

Scheduled for 0.9.24 milestone. Thanks @zonason!

@ajoslin
Copy link
Contributor

ajoslin commented Feb 11, 2014

@zonason can you tell me exactly how you reproduced this? I'm not able to.

A codepen would be great.

@zonason
Copy link
Author

zonason commented Feb 11, 2014

Thank you for responding, this is a big issue from what I can see. I
absolutely can put together a codepen, give me a couple days, I'm currently
in transit.
On Feb 11, 2014 3:05 PM, "Andy Joslin" notifications@github.com wrote:

@zonason https://github.com/zonason can you tell me exactly how you
reproduced this? I'm not able to.

A codepen would be great.

Reply to this email directly or view it on GitHubhttps://github.com//issues/557#issuecomment-34799546
.

@adamdbradley adamdbradley modified the milestones: 0.9.25, 0.9.24 Feb 12, 2014
@zonason
Copy link
Author

zonason commented Feb 14, 2014

Here's my codepen, I slimmed it down to core components. Notice when toggling the left or right side menus (or any programatically called scrolling events) that all content areas also scroll position.

http://codepen.io/anon/pen/Cevum

I've also created a video demonstrating the effect - http://youtu.be/BBRBRqxnLjo

@ajoslin
Copy link
Contributor

ajoslin commented Feb 17, 2014

OK, I see! I think this is actually due to $ionicScrollDelegate.tapScrollToTop() causing the content to scroll to top inadvertently when you click a button. I'll push a fix for scrollToTop() that makes it only work if the srcElement isn't part of a button.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants