Add integration for Coding.net

[mingshun]

This PR is for adding integration for Coding.net including platform and enterprise edition.

[CLAassistant]

All committers have signed the CLA.

[vangie]

+1

https://medium.com/flow-ci/github-vs-bitbucket-vs-gitlab-vs-coding-7cf2b43888a1

[fly88oj]

+1

[bradrydzewski]

thanks! I will start the review process and let you know if I have any comments. Great work!

[bradrydzewski]

cc @appleboy are you able to help review and push this through? Thanks! :)

[bradrydzewski]

@mingshun can you also update the conflict? thanks!

[appleboy]

@bradrydzewski I will test this PR after @mingshun fix conflicts.

[mingshun]

@appleboy conflicts fixed.

[bradrydzewski]

thanks! perhaps we can get this included in 0.8-rc.2

[bradrydzewski]

@mingshun as we prepare to review and get this merged, would you mind adding setup instructions to https://github.com/drone/docs/tree/master/content/install/integrations ? They should look similar to http://docs.drone.io/install-for-bitbucket-cloud/

thanks! :)

[appleboy]

LGTM. I already tested with https://coding.net/u/appleboy/p/go-hello/git repo. It is working for me. cc @bradrydzewski

[bradrydzewski]

just one minor change requested, but otherwise looks great :)

[bradrydzewski]

we should be able to derive the hostname from the DRONE_CODING_URL value. See https://github.com/drone/drone/blob/master/remote/gogs/gogs.go#L41:L47 for an example

[bradrydzewski]

we should be able to do something like this (which I mentioned in my prior comment) so that we can remove the DRONE_CODING_MACHINE environment variable.

const (
	defaultURL  = "https://coding.net" // Default Coding URL
+	defaultHost = "coding.net" // Default Coding Host
)


func New(opts Opts) (remote.Remote, error) {
	remote := &Coding{
		URL:        defaultURL,
		Client:     opts.Client,
		Secret:     opts.Secret,
		Scopes:     opts.Scopes,
-		Machine:    opts.Machine,
+		Machine:    defaultHost,
		Username:   opts.Username,
		Password:   opts.Password,
		SkipVerify: opts.SkipVerify,
	}
	if opts.URL != defaultURL {
		remote.URL = strings.TrimSuffix(opts.URL, "/")
+		url, err := url.Parse(remote.URL)
+		if err != nil {
+			return nil, err
+		}
+		host, _, err := net.SplitHostPort(url.Host)
+		if err == nil {
+			url.Host = host
+		}
+		remote.Machine  = host
	}

	// Hack to enable oauth2 access in coding's implementation
	oauth2.RegisterBrokenAuthHeaderProvider(remote.URL)
	return remote, nil
}

[mingshun]

The API hostname and Git hostname are different hostnames in Coding. So I have to keep the DRONE_CODING_GIT_MACHINE.

[bradrydzewski]

@mingshun can we use a default value for the machine? Is it safe to assume that if most users configure drone with the default url, they will also be able to use a default git host?

[mingshun]

@bradrydzewski But we have enterprise edition using another hostname. And we have self-host edition which may have even different hostnames.

[bradrydzewski]

ok, understood. I didn't realize coding.net could be self hosted as well :)

[bradrydzewski]

ok LGTM

now we just need some docs added to github.com/drone/docs

[mingshun]

@bradrydzewski added docs to drone/docs#228

[Youngv]

@mingshun Any update for Coding.net with the 0.8 version? It's not working now.