BZ1034030 : 0 byte local cache file in UrlResource

(cherry picked from commit 05196fa)
apache · Dec 18, 2013 · 1621e3b · 1621e3b
1 parent fe42528
commit 1621e3b
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/drools-core/src/main/java/org/drools/io/impl/UrlResource.java b/drools-core/src/main/java/org/drools/io/impl/UrlResource.java
@@ -173,12 +173,20 @@ private File getCacheFile()  {
         }
     }
 
+    private File getTemproralCacheFile()  {
+        try {
+            return new File(CACHE_DIR, URLEncoder.encode(this.url.toString(), "UTF-8") + "_tmp");
+        } catch (UnsupportedEncodingException e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     /**
      * Save a copy in the local cache - in case remote source is not available in future.
      */
     private void cacheStream() {
         try {
-            File fi = getCacheFile();
+            File fi = getTemproralCacheFile();
             if (fi.exists()) fi.delete();
             FileOutputStream fout = new FileOutputStream(fi);
             InputStream in = grabStream();
@@ -190,6 +198,9 @@ private void cacheStream() {
             fout.flush();
             fout.close();
             in.close();
+
+            File cacheFile = getCacheFile();
+            fi.renameTo(cacheFile);
         } catch (Exception e) {
             e.printStackTrace();
         }