- BZ-991487: read only fields now

- BZ-990996: now all the fields can be copied
kiegroup · Aug 16, 2013 · bd68471 · bd68471
1 parent 119bb4d
commit bd68471
Show file tree

Hide file tree

Showing 4 changed files with 79 additions and 73 deletions.
diff --git a/...g/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsPresenter.java b/...g/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsPresenter.java
@@ -16,6 +16,7 @@
 
 package org.jbpm.console.ng.pr.client.editors.instance.details;
 
+import com.github.gwtbootstrap.client.ui.Label;
 import java.util.List;
 import javax.enterprise.context.Dependent;
 import javax.inject.Inject;
@@ -24,6 +25,9 @@
 import com.github.gwtbootstrap.client.ui.TextArea;
 import com.github.gwtbootstrap.client.ui.TextBox;
 import com.google.gwt.core.client.GWT;
+import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
+import com.google.gwt.safehtml.shared.SafeHtmlUtils;
+import com.google.gwt.user.client.ui.HTML;
 import com.google.gwt.view.client.HasData;
 import com.google.gwt.view.client.ListDataProvider;
 import com.google.gwt.view.client.ProvidesKey;
@@ -69,23 +73,23 @@ public interface ProcessInstanceDetailsView extends UberView<ProcessInstanceDeta
 
         void displayNotification( String text );
 
-        ListBox getCurrentActivitiesListBox();
+        HTML getCurrentActivitiesListBox();
 
-        TextArea getLogTextArea();
+        HTML getLogTextArea();
 
-        TextBox getProcessInstanceIdText();
+        HTML getProcessInstanceIdText();
 
-        TextBox getProcessDefinitionIdText();
+        HTML getProcessDefinitionIdText();
 
-        TextBox getProcessNameText();
+        HTML getProcessNameText();
 
-        TextBox getStateText();
+        HTML getStateText();
 
         void setProcessInstance( ProcessInstanceSummary processInstance );
 
-        TextBox getProcessDeploymentText();
+        HTML getProcessDeploymentText();
 
-        TextBox getProcessVersionText();
+        HTML getProcessVersionText();
 
         void setProcessAssetPath( Path processAssetPath );
 
@@ -152,16 +156,17 @@ public void refreshProcessInstanceData( final String processId,
             @Override
             public void callback( List<NodeInstanceSummary> details ) {
                 view.getLogTextArea().setText( "" );
-                String fullLog = "";
+                SafeHtmlBuilder safeHtmlBuilder = new SafeHtmlBuilder();
                 for ( NodeInstanceSummary nis : details ) {
                     if(!nis.getNodeName().equals("")){
-                        fullLog += nis.getTimestamp() + ": " + nis.getId() + " - " + nis.getNodeName() + " (" + nis.getType()
-                                + ") \n";
+                        safeHtmlBuilder.appendEscapedLines(nis.getTimestamp() + ": " + nis.getId() + " - " + nis.getNodeName() + " (" + nis.getType()
+                                + ") \n" );
+
                     }else{
-                        fullLog += nis.getTimestamp() + ": " + nis.getId() + " - " + nis.getType() + "\n";
+                        safeHtmlBuilder.appendEscapedLines( nis.getTimestamp() + ": " + nis.getId() + " - " + nis.getType() + "\n");
                     }
                 }
-                view.getLogTextArea().setText( fullLog );
+                view.getLogTextArea().setHTML( safeHtmlBuilder.toSafeHtml() );
             }
         } ).getProcessInstanceHistory( Long.parseLong( processId ) );
 
@@ -170,13 +175,13 @@ public void callback( List<NodeInstanceSummary> details ) {
             @Override
             public void callback( List<NodeInstanceSummary> details ) {
                 view.setCurrentActiveNodes( details );
-                view.getCurrentActivitiesListBox().clear();
+                view.getCurrentActivitiesListBox().setText("");
+                SafeHtmlBuilder safeHtmlBuilder = new SafeHtmlBuilder();
                 for ( NodeInstanceSummary nis : details ) {
-
-                    view.getCurrentActivitiesListBox().addItem(
-                            nis.getTimestamp() + ":" + nis.getId() + " - " + nis.getNodeName() + " (" + nis.getType() + ")",
-                            String.valueOf( nis.getId() ) );
+                    safeHtmlBuilder.appendEscapedLines( nis.getTimestamp() + ":" + 
+                            nis.getId() + " - " + nis.getNodeName() + " (" + nis.getType() + ") \n");
                 }
+                view.getCurrentActivitiesListBox().setHTML(safeHtmlBuilder.toSafeHtml());
             }
         } ).getProcessInstanceActiveNodes( Long.parseLong( processId ) );
 

diff --git a/...rg/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsViewImpl.html b/...rg/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsViewImpl.html
@@ -4,51 +4,51 @@
     <div class="form-horizontal">
 
       <div class="control-group">
-        <label class="control-label" for="processInstanceIdText" data-field="processInstanceIdLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="processInstanceIdText" id="processInstanceIdText" placeholder="" />
+        <strong><label class="control-label" for="processInstanceIdText" data-field="processInstanceIdLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="processInstanceIdText" />
         </div>
       </div>  
       <div class="control-group">
-        <label class="control-label" for="processDefinitionIdText" data-field="processDefinitionIdLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="processDefinitionIdText" id="processDefinitionIdText" placeholder="" />
+        <strong><label class="control-label" for="processDefinitionIdText" data-field="processDefinitionIdLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="processDefinitionIdText" />
         </div>
       </div>
       <div class="control-group">
-        <label class="control-label" for="processNameText" data-field="processNameLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="processNameText" id="processNameText" placeholder="" />
+        <strong><label class="control-label" for="processNameText" data-field="processNameLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="processNameText" />
         </div>
       </div>
-      <div class="control-group">
-        <label class="control-label" for="processDeploymentText" data-field="processDeploymentLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="processDeploymentText" id="processDeploymentText" placeholder="" />
+      <div class="control-group ">
+        <strong><label class="control-label" for="processDeploymentText" data-field="processDeploymentLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="processDeploymentText" />
         </div>
       </div>
       <div class="control-group">
-        <label class="control-label" for="processVersionText" data-field="processVersionLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="processVersionText" id="processVersionText" placeholder="" />
+        <strong><label class="control-label" for="processVersionText" data-field="processVersionLabel"></label></strong>
+        <div class="controls readonly">
+          <label  data-field="processVersionText"/>
         </div>
       </div>
       <div class="control-group">
-        <label class="control-label" for="stateText" data-field="stateLabel"></label>
-        <div class="controls">
-          <input type="text" data-field="stateText" id="stateText" placeholder="" />
+          <strong><label class="control-label" for="stateText" data-field="stateLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="stateText" />
         </div>
       </div>
       <div class="control-group">
-        <label class="control-label" for="currentActivitiesListBox" data-field="currentActivitiesListLabel"></label>
-        <div class="controls">
-          <select data-field="currentActivitiesListBox" size="5" id="currentActivitiesListBox"></select>
+          <strong><label class="control-label" for="currentActivitiesListBox" data-field="currentActivitiesListLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="currentActivitiesListBox" />
         </div>
       </div>
       <div class="control-group">
-        <label class="control-label" for="logTextArea" data-field="logTextLabel"></label>
-        <div class="controls">
-          <textarea data-field="logTextArea" rows="10" id="logTextArea"></textarea>
+          <strong><label class="control-label" for="logTextArea" data-field="logTextLabel"></label></strong>
+        <div class="controls readonly">
+          <label data-field="logTextArea" />
         </div>
       </div>
     </div>

diff --git a/...rg/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsViewImpl.java b/...rg/jbpm/console/ng/pr/client/editors/instance/details/ProcessInstanceDetailsViewImpl.java
@@ -25,14 +25,11 @@
 import javax.inject.Inject;
 
 import com.github.gwtbootstrap.client.ui.DataGrid;
-import com.github.gwtbootstrap.client.ui.Heading;
 import com.github.gwtbootstrap.client.ui.Label;
 import com.github.gwtbootstrap.client.ui.ListBox;
-import com.github.gwtbootstrap.client.ui.NavLink;
 import com.github.gwtbootstrap.client.ui.SimplePager;
 import com.github.gwtbootstrap.client.ui.TextArea;
 import com.github.gwtbootstrap.client.ui.TextBox;
-import com.github.gwtbootstrap.client.ui.base.IconAnchor;
 import com.google.gwt.cell.client.ActionCell;
 import com.google.gwt.cell.client.ActionCell.Delegate;
 import com.google.gwt.cell.client.Cell;
@@ -41,19 +38,17 @@
 import com.google.gwt.cell.client.HasCell;
 import com.google.gwt.cell.client.TextCell;
 import com.google.gwt.core.client.GWT;
-import com.google.gwt.event.dom.client.ClickEvent;
-import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.i18n.client.DateTimeFormat;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.user.cellview.client.Column;
 import com.google.gwt.user.cellview.client.ColumnSortEvent;
 import com.google.gwt.user.client.ui.AbstractImagePrototype;
 import com.google.gwt.user.client.ui.Composite;
 import com.google.gwt.user.client.ui.FlowPanel;
+import com.google.gwt.user.client.ui.HTML;
 import com.google.gwt.user.client.ui.HTMLPanel;
 import java.util.Date;
 import org.jboss.errai.ui.shared.api.annotations.DataField;
-import org.jboss.errai.ui.shared.api.annotations.EventHandler;
 import org.jboss.errai.ui.shared.api.annotations.Templated;
 import org.jbpm.console.ng.pr.client.i18n.Constants;
 import org.jbpm.console.ng.pr.client.resources.ProcessRuntimeImages;
@@ -79,7 +74,7 @@ public class ProcessInstanceDetailsViewImpl extends Composite implements
 
     @Inject
     @DataField
-    public TextBox processDefinitionIdText;
+    public HTML processDefinitionIdText;
 
 
     @Inject
@@ -88,35 +83,35 @@ public class ProcessInstanceDetailsViewImpl extends Composite implements
 
     @Inject
     @DataField
-    public TextBox processInstanceIdText;
+    public HTML processInstanceIdText;
 
     @Inject
     @DataField
-    public TextBox processNameText;
+    public HTML processNameText;
 
     @Inject
     @DataField
-    public TextBox processDeploymentText;
+    public HTML processDeploymentText;
 
     @Inject
     @DataField
     public FlowPanel listContainer;
 
     @Inject
     @DataField
-    public TextBox processVersionText;
+    public HTML processVersionText;
 
     @Inject
     @DataField
-    public TextBox stateText;
+    public HTML stateText;
 
     @Inject
     @DataField
-    public ListBox currentActivitiesListBox;
+    public HTML currentActivitiesListBox;
 
     @Inject
     @DataField
-    public TextArea logTextArea;
+    public HTML logTextArea;
 
     @Inject
     @DataField
@@ -178,14 +173,14 @@ public class ProcessInstanceDetailsViewImpl extends Composite implements
     public void init( final ProcessInstanceDetailsPresenter presenter ) {
         this.presenter = presenter;
 
-        processDefinitionIdText.setEnabled( false );
-        processInstanceIdText.setEnabled(false);
-        processNameText.setEnabled( false );
-        processDeploymentText.setEnabled( false );
-        processVersionText.setEnabled( false );
-        stateText.setEnabled( false );
-        logTextArea.setEnabled( false );
-        currentActivitiesListBox.setEnabled( false );
+        processDefinitionIdText.setStyleName("");
+        processInstanceIdText.setStyleName("");
+        processNameText.setStyleName("");
+        processDeploymentText.setStyleName("");
+        processVersionText.setStyleName("");
+        stateText.setStyleName("");
+        logTextArea.setStyleName("");
+        currentActivitiesListBox.setStyleName("");
 
         listContainer.add( processDataGrid );
 
@@ -230,17 +225,17 @@ public void init( final ProcessInstanceDetailsPresenter presenter ) {
 
 
     @Override
-    public TextBox getProcessDefinitionIdText() {
+    public HTML getProcessDefinitionIdText() {
         return processDefinitionIdText;
     }
 
     @Override
-    public ListBox getCurrentActivitiesListBox() {
+    public HTML getCurrentActivitiesListBox() {
         return currentActivitiesListBox;
     }
 
     @Override
-    public TextArea getLogTextArea() {
+    public HTML getLogTextArea() {
         return logTextArea;
     }
 
@@ -250,7 +245,7 @@ public void displayNotification( String text ) {
     }
 
     @Override
-    public TextBox getProcessNameText() {
+    public HTML getProcessNameText() {
         return processNameText;
     }
 
@@ -372,7 +367,7 @@ public VariableSummary getValue( VariableSummary object ) {
     }
 
     @Override
-    public TextBox getProcessInstanceIdText() {
+    public HTML getProcessInstanceIdText() {
         return this.processInstanceIdText;
     }
 
@@ -467,17 +462,17 @@ public void setProcessInstance( ProcessInstanceSummary processInstance ) {
     }
 
     @Override
-    public TextBox getStateText() {
+    public HTML getStateText() {
         return this.stateText;
     }
 
     @Override
-    public TextBox getProcessDeploymentText() {
+    public HTML getProcessDeploymentText() {
         return processDeploymentText;
     }
 
     @Override
-    public TextBox getProcessVersionText() {
+    public HTML getProcessVersionText() {
         return processVersionText;
     }
 

diff --git a/...ocess-runtime-client/src/main/resources/org/jbpm/console/ng/pr/public/css/ProcessList.css b/...ocess-runtime-client/src/main/resources/org/jbpm/console/ng/pr/public/css/ProcessList.css
@@ -13,6 +13,12 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
+.controls.readonly
+{
+  padding-top: 5px;
+}
+
 .icon-jbpm-signal{
    background-image: url(../images/icons/signal-grid-icon.png) !important; 
    display: inline-block;