More BZ1007781 - Editors should not contain file extension of assets

(cherry picked from commit bc51a7d)
kiegroup · Sep 20, 2013 · 5dc0898 · 5dc0898
1 parent 71aa13b
commit 5dc0898
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 18 deletions.
diff --git a/...workbench/common/screens/defaulteditor/client/editor/GuvnorTextEditorScreenPresenter.java b/...workbench/common/screens/defaulteditor/client/editor/GuvnorTextEditorScreenPresenter.java
@@ -1,28 +1,33 @@
 package org.kie.workbench.common.screens.defaulteditor.client.editor;
 
 import javax.enterprise.context.Dependent;
+import javax.inject.Inject;
 
 import com.google.gwt.user.client.ui.IsWidget;
 import org.uberfire.client.annotations.WorkbenchEditor;
 import org.uberfire.client.annotations.WorkbenchPartTitle;
 import org.uberfire.client.annotations.WorkbenchPartView;
 import org.uberfire.client.editors.texteditor.TextResourceType;
 import org.uberfire.lifecycle.OnOpen;
-import org.uberfire.util.FileNameUtil;
+import org.uberfire.workbench.type.FileNameUtil;
 
 @Dependent
-@WorkbenchEditor(identifier = "GuvnorTextEditor", supportedTypes = {TextResourceType.class}, priority = -1)
+@WorkbenchEditor(identifier = "GuvnorTextEditor", supportedTypes = { TextResourceType.class }, priority = -1)
 public class GuvnorTextEditorScreenPresenter
         extends GuvnorTextEditorPresenter {
 
+    @Inject
+    private TextResourceType type;
+
     @OnOpen
     public void onOpen() {
         super.onOpen();
     }
 
     @WorkbenchPartTitle
     public String getTitle() {
-        return "Text Editor [" + FileNameUtil.removeExtension(path.getFileName()) + "]";
+        return "Text Editor [" + FileNameUtil.removeExtension( path,
+                                                               type ) + "]";
     }
 
     @WorkbenchPartView

diff --git a/...n/java/org/kie/workbench/common/screens/javaeditor/client/editor/JavaEditorPresenter.java b/...n/java/org/kie/workbench/common/screens/javaeditor/client/editor/JavaEditorPresenter.java
@@ -33,13 +33,12 @@
 import org.uberfire.client.common.MultiPageEditor;
 import org.uberfire.client.common.Page;
 import org.uberfire.client.editors.texteditor.TextEditorPresenter;
-import org.uberfire.lifecycle.OnClose;
 import org.uberfire.lifecycle.OnStartup;
-import org.uberfire.util.FileNameUtil;
+import org.uberfire.workbench.type.FileNameUtil;
 
 import static org.kie.commons.validation.PortablePreconditions.*;
 
-@WorkbenchEditor(identifier = "JavaEditor", supportedTypes = {JavaResourceType.class})
+@WorkbenchEditor(identifier = "JavaEditor", supportedTypes = { JavaResourceType.class })
 public class JavaEditorPresenter
         extends TextEditorPresenter {
 
@@ -54,39 +53,43 @@ public class JavaEditorPresenter
     @Inject
     private MultiPageEditor multiPage;
 
+    @Inject
+    private JavaResourceType type;
+
     @OnStartup
-    public void init(final Path path) {
-        this.path = checkNotNull("path", path);
+    public void init( final Path path ) {
+        this.path = checkNotNull( "path", path );
 
-        super.onStartup(path);
+        super.onStartup( path );
 
         this.path = path;
 
         IsWidget widget = super.getWidget();
         multiPage.addWidget(
                 widget,
-                CommonConstants.INSTANCE.EditTabTitle());
+                CommonConstants.INSTANCE.EditTabTitle() );
 
-        multiPage.addPage(new Page(metadataWidget,
-                CommonConstants.INSTANCE.MetadataTabTitle()) {
+        multiPage.addPage( new Page( metadataWidget,
+                                     CommonConstants.INSTANCE.MetadataTabTitle() ) {
             @Override
             public void onFocus() {
-                metadataWidget.showBusyIndicator(CommonConstants.INSTANCE.Loading());
-                metadataService.call(new MetadataSuccessCallback(metadataWidget,
-                        isReadOnly),
-                        new HasBusyIndicatorDefaultErrorCallback(metadataWidget)).getMetadata(path);
+                metadataWidget.showBusyIndicator( CommonConstants.INSTANCE.Loading() );
+                metadataService.call( new MetadataSuccessCallback( metadataWidget,
+                                                                   isReadOnly ),
+                                      new HasBusyIndicatorDefaultErrorCallback( metadataWidget ) ).getMetadata( path );
             }
 
             @Override
             public void onLostFocus() {
                 //Nothing to do
             }
-        });
+        } );
     }
 
     @WorkbenchPartTitle
     public String getTitle() {
-        return "Java Editor [" + FileNameUtil.removeExtension(path.getFileName()) + "]";
+        return "Java Editor [" + FileNameUtil.removeExtension( path,
+                                                               type ) + "]";
     }
 
     @WorkbenchPartView