Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-Gen to print warnings about duplicate genesis events for the same storm. #1380

Closed
18 tasks done
JohnHalleyGotway opened this issue Jun 18, 2020 · 0 comments
Closed
18 tasks done
Assignees
Labels
MET: Library Code priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jun 18, 2020

Describe the Enhancement

When running TC-Gen, Dan Adriaansen found a discrepancy between the number of BEST track genesis events reported (209) versus the number of unique lat/lon locations listed in the log file (202). Genesis at the same lat/lon location and time were counted twice seven times. In all 7 cases, genesis was identified both in the INVEST and the numbered storm. This can easily be avoided by ignoring the INVEST track files or by setting a minimum category threshold, such as:
category = [ "TD", "TS"];

To make the code more user-friendly, identify these situations and print a warning message about them. Then the user can decide how to proceed.

For example, the first duplicate occurs in these 2 files...
kiowa:/d1/dadriaan/projects/s2s/tc/data/weiwei/obs/allvigh> egrep "119N, 1416W," b*
bcp012018.dat:CP, 01, 2018092618, , BEST, 0, 119N, 1416W, 25, 1008, DB, 0, , 0, 0, 0, 0, 1009, 180, 50, 0, 0, , 0, , 0, 0, INVEST, ,
bcp972018.dat:CP, 97, 2018092618, , BEST, 0, 119N, 1416W, 25, 1008, DB, 0, , 0, 0, 0, 0, 1009, 180, 50, 0, 0, , 0, , 0, 0, INVEST, ,

And the second duplicate occurs in these 2 files:
kiowa:/d1/dadriaan/projects/s2s/tc/data/weiwei/obs/allvigh> egrep "145N, 832W," b*
bal142018.dat:AL, 14, 2018100418, , BEST, 0, 145N, 832W, 20, 1007, DB, 0, , 0, 0, 0, 0, 1009, 100, 90, 0, 0, , 0, , 0, 0, GENESIS036, , 0, , 0, 0, 0, 0, genesis-num, 036,
bal912018.dat:AL, 91, 2018100418, , BEST, 0, 145N, 832W, 20, 1007, DB, 0, , 0, 0, 0, 0, 1009, 100, 90, 0, 0, , 0, , 0, 0, GENESIS036, , 0, , 0, 0, 0, 0, genesis-num, 036,

Time Estimate

4 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • No sub-issues needed.

Relevant Deadlines

NONE

Funding Source

TC-Gen Project

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John Halley Gotway
  • Select scientist(s) or no scientist required: Dan Adriaansen

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: library code priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory labels Jun 18, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1 milestone Jun 18, 2020
JohnHalleyGotway added a commit that referenced this issue Jun 18, 2020
…m() member functions. When adding a new Genesis event, print warning messages if a duplicate or a match for that same storm exists.
@JohnHalleyGotway JohnHalleyGotway added this to Pull request review in MET-9.1-beta2 (7/14/20) Jun 18, 2020
JohnHalleyGotway added a commit that referenced this issue Jun 24, 2020
* Per #1380, only list the oper_event.technique name in the log message if it's non-empty.

* Per #1380, add GenesisInfo::is_storm() and GenesisInfoArray::has_storm() member functions. When adding a new Genesis event, print warning messages if a duplicate or a match for that same storm exists.
MET-9.1-beta2 (7/14/20) automation moved this from Pull request review to Done Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Library Code priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

No branches or pull requests

2 participants