Check for inconsistent setting of flags (-D__64BIT__) in MET and the GRIB2C library

[jprestop]

Describe the Enhancement

When the GRIB2 flags are set inconsistently, MET’s GRIB2 library code thinks it needs to read a ridiculously large amount of memory. We want to find that spot, add a sanity check, and print a warning message message if requesting an unreasonable amount of memory. Don't make it an error message on the off chance that whatever size threshold we choose is too small for some user. This issue comes up often enough in met_help issues where it seems worthwhile to add a check in the code.

Can test using the data in /d3/personal/jpresto/met_help/shilpi_kalra_20200712.
Run: pcp_combine -subtract WRFPRS_d01.48 48 WRFPRS_d01.24 24 APCP.nc
Compile a version of MET where there is inconsistent setting of the -D__64BIT__ flag between the GRIB2C library and MET.

Time Estimate

4 hours.

Sub-Issues

No sub-issues needed.

Relevant Deadlines

NONE

Funding Source

NONE

Define the Metadata

Assignee

• Select engineer(s) or no engineer required: John Halley Gotway
• Select scientist(s) or no scientist required: No scientist needed

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Review projects and select relevant Repository and Organization ones
• Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.

[JohnHalleyGotway]

Testing on dakota in /d3/personal/johnhg/MET/MET_development/MET-feature_1416_64bit.
I had been compiling on dakota using:

CFLAGS=-g -DUNDERSCORE -fPIC -D__64BIT__
CXXFLAGS=-g -DUNDERSCORE -fPIC -D__64BIT__

For this work, I removed the -D__64BIT__ flag from these settings and recompiled and tested by running:

/d3/personal/johnhg/MET/MET_development/MET-feature_1416_64bit/met/bin/pcp_combine -subtract \
/d3/personal/jpresto/met_help/shilpi_kalra_20200712/WRFPRS_d01.48 48 \
/d3/personal/jpresto/met_help/shilpi_kalra_20200712/WRFPRS_d01.24 24 \
APCP.nc

ERROR  : 
ERROR  : out of memory!  Exiting!
ERROR  :

[JohnHalleyGotway]

Added a new oom_grib2() function and call set_new_handler() to point to it inside the GRIB2 library code. Retest to produce this new out of memory error message:

ERROR  : 
ERROR  : Out of memory reading GRIB2 data!  Exiting!
ERROR  : Check that MET and the GRIB2C library were compiled consistently, either with or without the -D__64BIT__ flag.
ERROR  :