Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported grids and their definition templates to the documentation #1469

Closed
8 of 18 tasks
DanielAdriaansen opened this issue Aug 25, 2020 · 5 comments
Closed
8 of 18 tasks
Assignees
Labels
component: documentation Documentation issue MET: Python Embedding priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Aug 25, 2020

Describe the Enhancement

Python embedding requires that the user specify a "grid" attribute of the data. This attribute must conform to MET's way for specifying grids, which is currently not readily accessible outside the source code. Add a section containing these grid definition templates to the documentation.

Should it go in the user's guide or contributor's guide?

Time Estimate

4 hours

Relevant Deadlines

NONE

Funding Source

NONE

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop and link the pull request to this issue..
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: enhancement Improve something that it is currently doing component: documentation Documentation issue component: python interface priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to the MET 10.0 milestone Aug 25, 2020
@DanielAdriaansen DanielAdriaansen self-assigned this Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to To do in MET-10.0.0-beta1 (10/22/20) via automation Aug 25, 2020
@DanielAdriaansen
Copy link
Contributor Author

Seems like a lot of this information could be obtained from the *_defs.h files here: https://github.com/dtcenter/MET/tree/master_v9.1/met/src/libcode/vx_grid.

John also suggested running GRIBv2 files through pcp_combine to generate netCDF output, where one could view the CF_compliant grid information which comes from the MET projection code.

@DanielAdriaansen
Copy link
Contributor Author

Actually, after further review it looks like Python embedding has it's own grid support which may or may not be the same as what MET might support. All of the grid definitions Python embedding supports are located in in this file:
https://github.com/dtcenter/MET/blob/master_v9.1/met/src/libcode/vx_data2d_python/grid_from_python_dict.cc

These definitions are what should be documented for Python embedding. If there are additional grids MET supports that are not included here, then we need to probably align the Python embedding support with MET support so that we don't have to document these twice.

@DanielAdriaansen
Copy link
Contributor Author

@JohnHalleyGotway JohnHalleyGotway added this to To do in MET-10.0.0-rc1 (5/10/21) via automation Feb 16, 2021
@JohnHalleyGotway
Copy link
Collaborator

@DanielAdriaansen can you please take a look at this issue to see if the work is done? And if so, please close it.

@JohnHalleyGotway JohnHalleyGotway self-assigned this Apr 30, 2021
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Apr 30, 2021
@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 30, 2021

@JohnHalleyGotway and @DanielAdriaansen discussed this on 4/30/21 and agree that the existing documentation in Appendix F describes the grid definition components well for each supported projection. No additional work is required at this time. However, when support for additional projections is added to MET, the documentation should be updated at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue MET: Python Embedding priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

No branches or pull requests

2 participants