Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ncdump in Docker image. #1554

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Nov 10, 2020 · 0 comments · Fixed by #1555 or #1556
Closed
8 of 21 tasks

Fix ncdump in Docker image. #1554

JohnHalleyGotway opened this issue Nov 10, 2020 · 0 comments · Fixed by #1555 or #1556
Assignees
Labels
component: build process Build process issue priority: blocker Blocker requestor: NCAR National Center for Atmospheric Research type: bug Fix something that is not working

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Problem

In testing METplus, George has found that running ncdump inside a MET Docker container often doesn't work. Instead it errors out. In testing, we have found that it's related to how the NetCDF, HDF4, and HDFEOS libraries are compiled. Recommend updating the Dockerfile to install HDF and HDFEOS into subdirectories of /usr/local and then ensure that ncdump still runs fine.

Once fixed, consider retagging MET version 9.1 so that ncdump is functional within that image.

Expected Behavior

The ncdump utility should run on all valid NetCDF files within the MET docker container.

Environment

Describe your runtime environment:
1. Machine: Docker Container
2. Software version number(s): images for version number met-9.1, develop, and likely others

To Reproduce

Describe the steps to reproduce the behavior:

docker pull dtcenter/met:9.1
docker create --name medium_range dtcenter/metplus-data:3.1-medium_range
docker run --rm -it --volumes-from medium_range dtcenter/met:9.1
ncdump -h /data/input/METplus_Data/model_applications/medium_range/grid_to_obs/netcdf/nam/conus_sfc/prepbufr.nam.20170601.t00z.tm00.nc

Relevant Deadlines

None.

Funding Source

None.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG (George to review PR)
  • Select scientist(s) or no scientist required: No scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: build process Build process issue priority: blocker Blocker requestor: NCAR National Center for Atmospheric Research labels Nov 10, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1.1 (bugfix) milestone Nov 10, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Nov 10, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in METplus Version 3.1 Support via automation Nov 10, 2020
JohnHalleyGotway added a commit that referenced this issue Nov 10, 2020
…f /usr/local to avoid conflicts with NetCDF that caused /usr/local/bin/ncdump to fail.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 10, 2020 that will close this issue
8 tasks
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 10, 2020 that will close this issue
METplus Version 3.1 Support automation moved this from To do to Done Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue priority: blocker Blocker requestor: NCAR National Center for Atmospheric Research type: bug Fix something that is not working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant