Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H_RATE and PODY, separate definitions #1631

Closed
10 of 22 tasks
j-opatz opened this issue Jan 22, 2021 · 1 comment
Closed
10 of 22 tasks

Update H_RATE and PODY, separate definitions #1631

j-opatz opened this issue Jan 22, 2021 · 1 comment
Assignees
Labels
component: documentation Documentation issue priority: low Low Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work

Comments

@j-opatz
Copy link
Contributor

j-opatz commented Jan 22, 2021

Replace italics below with details for this issue.

Describe the Task

In the process of reviewing statistical output, it was found that the H_RATE and PODY values differed. According to the User's Manual (Appendix C), these two values are identical.
However, after review of their internal calculation and true definition, it was concluded that the User's Guide was in error.

Time Estimate

15 minutes

Sub-Issues

  • Remove H_RATE from current definition
  • Add new definition for H_RATE, where H_RATE = n(1,1)/T

Relevant Deadlines

None

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@j-opatz j-opatz added component: documentation Documentation issue type: task An actionable item of work priority: low Low Priority requestor: METplus Team METplus Development Team labels Jan 22, 2021
@j-opatz j-opatz self-assigned this Jan 22, 2021
@j-opatz j-opatz added this to To do in MET-10.0.0-beta3 (1/27/21) via automation Jan 22, 2021
@j-opatz j-opatz moved this from To do to Done in MET-10.0.0-beta3 (1/27/21) Jan 22, 2021
@j-opatz
Copy link
Contributor Author

j-opatz commented Jan 22, 2021

Appendix C was updated with new, split definitions.
Noting that this may ned to be revisited, as the PointStat table still indicates that H_RATE is hit rate, but it is not conventionally known as such.

@j-opatz j-opatz closed this as completed Jan 22, 2021
@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: low Low Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
No open projects
Development

No branches or pull requests

2 participants