Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fv3_physics_tend for new FV3 output format #380

Open
26 of 33 tasks
ahijevyc opened this issue Aug 2, 2023 · 0 comments · May be fixed by #382
Open
26 of 33 tasks

Update fv3_physics_tend for new FV3 output format #380

ahijevyc opened this issue Aug 2, 2023 · 0 comments · May be fixed by #382
Assignees
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: plot gridded data METplotpy: Plots priority: medium Medium Priority requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing

Comments

@ahijevyc
Copy link
Contributor

ahijevyc commented Aug 2, 2023

Replace italics below with details for this issue.

Describe the Enhancement

Update contributed/fv3_physics_tend
Read and plot FV3 physics tendencies from new FV3 output format.

Time Estimate

Estimate the amount of work required here.
7 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • adapt planview_fv3.py for new formulation of no-physics (advection) tendency. Now it is reset every output just like the other tendencies. This simplifies the code. However, it can't simply be addressed in the config file.
  • adapt cross_section_vert.py for new nophys
  • adapt vert_profile_fv3.py for new nophys
  • add "actual" tendency panel to the multi-panel plan view plot
  • add --robust command line option to control colormap range to planview_fv3.py and cross_section_vert.py
  • fix bug in time-averaging window in planview, cross_section_vert, and vert_profile_fv3.
  • retain units on xarray xaxis in vert_profile_fv3.py
  • add vmin, vmax to planview and cross section
  • add xmin, xmax to vert_profile_fv3.py
  • clean code, leaving out unnecessary function arguments, use pep8 filter
  • update history file
  • update example plot output PNGs

Relevant Deadlines

NONE

Funding Source

NONE

Define the Metadata

Assignee

  • Select engineer
  • Select scientist

Labels

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@ahijevyc ahijevyc added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Aug 2, 2023
@ahijevyc ahijevyc self-assigned this Aug 2, 2023
@ahijevyc ahijevyc added priority: medium Medium Priority component: plot gridded data requestor: NOAA/other NOAA Laboratory, not otherwise specified METplotpy: Plots and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Aug 2, 2023
@ahijevyc ahijevyc added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Aug 4, 2023
@ahijevyc ahijevyc added this to the Consider for Next Release milestone Aug 4, 2023
This was linked to pull requests Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: plot gridded data METplotpy: Plots priority: medium Medium Priority requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing
Projects
Status: 👀 In review
2 participants