Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance METviewer to load the additional climatology column in the ORANK line type updated for met-10.0.0. #261

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Feb 22, 2021 · 5 comments · Fixed by #264
Assignees
Labels
priority: blocker Blocker reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Feb 22, 2021

Describe the Enhancement

dtcenter/MET#1451 makes two changes to the ORANK line type created by Ensemble-Stat. It renames the existing column from CLIMO to CLIMO_MEAN and addends a new column to the end of the line names CLIMO_STDEV. The updated line type will be available in the met-10.0.0-beta4 release. This task is to enhance METviewer to load the updated contents of the ORANK line type for MET version 10.0.0.

@JohnHalleyGotway will provide an updated sample data file as soon as one is available.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required.

Relevant Deadlines

METplus 4.0 release

Funding Source

?

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: Tatiana
  • Select scientist(s) or no scientist required: no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway
Copy link
Contributor Author

Please find updated version of the ORANK line type for met-10.0.0 attached:
sample_orank.tar.gz.txt
(Note: added .txt to the tarfile name to trick GitHub)

@TatianaBurek
Copy link
Collaborator

Attached sample_orank.tar.gx file contains .txt files that are not compatible with METviewer. METviewer needs .stat files

@JohnHalleyGotway
Copy link
Contributor Author

Please see this comment to METviewer #259 for sample stat data:
#259 (comment)

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Mar 2, 2021

ORANK_CLIMO_STDEV is added to UI
CLIMO was renamed to CLIMO_MEAN

TatianaBurek added a commit that referenced this issue Mar 2, 2021
@TatianaBurek TatianaBurek linked a pull request Mar 2, 2021 that will close this issue
9 tasks
@TatianaBurek TatianaBurek added this to To do in METviewer-4.0-beta4 (3/1/21) via automation Mar 2, 2021
@TatianaBurek TatianaBurek moved this from To do to Pull request review in METviewer-4.0-beta4 (3/1/21) Mar 2, 2021
@TatianaBurek TatianaBurek removed this from Pull request review in METviewer-4.0-beta4 (3/1/21) Mar 3, 2021
@TatianaBurek TatianaBurek added this to To Do in METviewer-4.0-beta5 (4/21/27) via automation Mar 3, 2021
@TatianaBurek TatianaBurek moved this from To Do to In Progress in METviewer-4.0-beta5 (4/21/27) Mar 3, 2021
@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Mar 8, 2021

OBS_QC column form ORANK and MPR line types have type double but while PB2NC stores quality control values as integers (lower is better), in MADIS, they're stored as strings. So in MET, we store and write them as strings.
METviewer should change the type pf these columns to strings

TatianaBurek added a commit that referenced this issue Mar 8, 2021
@TatianaBurek TatianaBurek moved this from In Progress to Pull Request in METviewer-4.0-beta5 (4/21/27) Mar 8, 2021
@TatianaBurek TatianaBurek moved this from Pull Request to Done in METviewer-4.0-beta5 (4/21/27) Mar 23, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Mar 31, 2021
@TaraJensen TaraJensen added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants