Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save molecules back to archives if changes are made #31

Open
karlduderstadt opened this issue Feb 27, 2021 · 0 comments
Open

Only save molecules back to archives if changes are made #31

karlduderstadt opened this issue Feb 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@karlduderstadt
Copy link
Member

We should keep track of whether anything was changed in records before calling put to return molecule records to the archive. In the case of virtual archives the put method triggers saving of the record back to file, which can be time consuming and is not needed if you are quickly just looking through traces. Checking first and only saving if something changed could improve performance.

Another option would be to delegate the saving to a background thread, however, how then should we handle the case where someone goes forward on record and then directly back to the previous record before it is done saving? This can all be done, but would take some work. First we should try and only save if changes are made, this would catch most use cases.

@karlduderstadt karlduderstadt added the enhancement New feature or request label Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant