Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: show git commits between currently installed version and newly available version #339

Open
dburr opened this issue May 3, 2023 · 1 comment
Labels
✨ feature request New feature or request
Milestone

Comments

@dburr
Copy link

dburr commented May 3, 2023

Is your feature request related to a problem? Please describe

Keeping track of software, especially Klipper, is difficult since it is a moving target. It would be extremely useful to be able to view the differences/changes between the version you are currently running and the newly available version, to judge whether or not it is justified to run the upgrade. (Klipper upgrades in particular are kind of a pain, since I have to build klipper for two microcontroller architectures, pull out SD cards/RP2040s/etc. and do firmware upgrades, etc.)

Describe the solution you'd like

In Mainsail's Update manager, when an update is detected, you can view the commit history from between what you are currently running and the newly updated version.

Screenshot 2023-05-03 at 3 32 28 PM
Screenshot 2023-05-03 at 3 32 34 PM

It would be extremely handy if KIAUH could do the same.

Describe alternatives you've considered

You can go open a web browser and view the relevant repository on github, but it is kind of unwieldy and inconvenient, plus the information isn't "right there" in your terminal window.

Additional information

I see two ways of doing this.

  1. actually display the commit logs between the current versions in the terminal

  2. generate a clickable Github link to show the differences between the current version and the new version. How to generate "view commits between X and Y" links on github

1 would probably require you to prefetch the new repository so as to generate the list of commits between current and new version. Not sure if that can be easily accomplished. 2 is probably easier to implement and would be an acceptable solution.

@dburr dburr added the ✨ feature request New feature or request label May 3, 2023
@dw-0
Copy link
Owner

dw-0 commented Jun 4, 2023

If i would implement that feature, i would definitely go with option 2.
the question would be, where to display that link? if i understand your request correctly you would like to see those changelists BEFORE actually executing the updating of the repo. a possible way would be to have some kind of dialog before the actual update. something like "the recent changes can be seen here , do you still want to update?" after you selected klipper in the update menu for example and then a yes/no input to confirm.

@dw-0 dw-0 added this to the next milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants