Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupify #15

Open
amvaleh opened this issue Sep 7, 2014 · 3 comments
Open

Groupify #15

amvaleh opened this issue Sep 7, 2014 · 3 comments

Comments

@amvaleh
Copy link

amvaleh commented Sep 7, 2014

Hi
I am novice on rails and i am working on a grouping-social project .
the problem is that adding a user in a group with a certain membership-type, automatically adds 2 records, one is the default one and two is the specific type we want.
my grouping system has join request and pending requests that i want to use with groupify's membership type, I dont need records with nil membershiptype !!
Can you provide the gem without duplicate records ?
Sincerely Yours :D
am , valeh

@dwbutler
Copy link
Owner

dwbutler commented Sep 8, 2014

Hi, thanks for trying out Groupify!

This is actually expected behavior that is documented in the Readme. Is it causing an actual problem for your application, or is just annoying to see (supposedly) unnecessary rows in the database?

It might help if you could describe in more detail how you are using Groupify to implement your use case. It sounds like you're using membership type to track the "status" of a group membership request, e.g. group.add(user, as: 'requested'). Is this correct?

@amvaleh
Copy link
Author

amvaleh commented Sep 8, 2014

Hi again ,
yes I read the Readme, as you said, it is causing an actual problem.
and the problem is exactly as you described , correct.
I do not want the rows with empty membership type to be created because of memory matters...
( by the way, I jumped in to the gem, and changed the group.rb and it is now a solved problem for me, but it might not be a bad idea to provide the ability: block the repetitive records if coder wanted to !! )
Thanks 4 ur attention

@dwbutler
Copy link
Owner

dwbutler commented Sep 8, 2014

I can understand why you might find the default group membership row redundant. I will consider making that behavior configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants