Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with other packages #46

Open
Roh-codeur opened this issue Dec 9, 2022 · 4 comments
Open

Incompatible with other packages #46

Roh-codeur opened this issue Dec 9, 2022 · 4 comments

Comments

@Roh-codeur
Copy link

hey mate, it appears that installing Indicators downgrades HTTP. Can you please help with this

⌅ [cd3eb016] ↓ HTTP v1.5.5 ⇒ v0.9.17

ta!

@Roh-codeur
Copy link
Author

it turns out the issue is with package Temporal.jl which has a hard dependency on HTTP 0.9. I have tried updating that and running tests, it all works fine. although, the URLs in that package seem out-of-date. I can submit a PR, but doesn't look like I have rights to create a branch

is this something you can help with please?

ta!

@kpa28-git
Copy link

kpa28-git commented Feb 14, 2023

It would be nice if Indicators.jl didn't depend on Temporal.jl, as this prevents me from using Indicators.jl as well. The Julian way seems to be to make all packages as minimal wrt dependencies and functionality as possible, that makes for a more composable ecosystem. I think it's better to target AbstractArray and maybe Tables.jl and leave more concrete type integrations for downstream packages (ie TemporalIndicators.jl).

@smishr
Copy link

smishr commented Mar 2, 2023

Yes if AbstractArray or Tables.jl are targetted by the package, it can be more compatible in the DataFrames ecosystem.

For example, I am planning to use these technical indicators on TSFrames objects

@smishr
Copy link

smishr commented Sep 15, 2023

Switching to package extensions for integrating Temporal.jl could solve this issue.

JuliCon23 demo, documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants