New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SerializationTest : Replace AssertJ's deprecated asList()
DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class))
#3027
Comments
asList()
DSL method with asInstanceOf(InstanceOfAssertFactories.LIST)
asList()
DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class))
Hi @rohanKanojia I'd like to work on this as my first contribution. Could you please assign this to me? |
@jasonmokk : Hello, Even if you are quite skilled, please consider doing one little (first-timers-only ) issue to get used to the process. After that, you are invited to move on up to the more difficult tasks, leaving some of the easy tasks to others so they can get involved and achieve change themselves. Maybe you should start with issues created for first timers first-timers-only |
@rohanKanojia My apologies, thank you for informing me about the process. I will look into the first-timers-only issues |
Hello, may I have this issue assigned to me now? |
…ethod with asInstanceOf(InstanceOfAssertFactories.list(type.class)) Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
…ethod with asInstanceOf(InstanceOfAssertFactories.list(type.class)) Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
…nTest (3039) Chore #3027: Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) Signed-off-by: Jason Mok <jjasonmok1@gmail.com> --- Remove use of wildcard import Signed-off-by: Jason Mok <jjasonmok1@gmail.com> --- Resolve dependency issues Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Component
None
Task description
Description
In the latest versions of Assertj
asList()
DSL method has been marked as deprecated:jkube/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/SerializationTest.java
Lines 84 to 85 in 91be299
users are advised to use
asInstanceOf(InstanceOfAssertFactories.list(type.class))
instead, we need to updateasList()
calls with this. Once we use it, we can omitisInstanceOf(Pod.class)
from line 85Expected Behavior
AssertJ's
asList()
is replaced withasInstanceOf(InstanceOfAssertFactories.list(type.class))
Acceptance Criteria
asList()
DSL method call is replaced withasInstanceOf(InstanceOfAssertFactories.list(type.class))
in SerializationTestisInstanceOf(Pod.class)
is removedThe text was updated successfully, but these errors were encountered: