Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3027

Closed
2 tasks
rohanKanojia opened this issue May 8, 2024 · 4 comments · Fixed by #3039
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented May 8, 2024

Component

None

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

.extracting("objects").asList().singleElement()
.isInstanceOf(Pod.class)

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this. Once we use it, we can omit isInstanceOf(Pod.class) from line 85

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in SerializationTest
  • isInstanceOf(Pod.class) is removed
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2024
@rohanKanojia rohanKanojia changed the title SerializationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.LIST) SerializationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) May 8, 2024
@jasonmokk
Copy link
Contributor

Hi @rohanKanojia I'd like to work on this as my first contribution. Could you please assign this to me?

@rohanKanojia
Copy link
Member Author

rohanKanojia commented May 9, 2024

@jasonmokk : Hello, help wanted issues are created for contributors who have already contributed to the project. I can see that you haven’t contributed to the project before.

Even if you are quite skilled, please consider doing one little (first-timers-only ) issue to get used to the process. After that, you are invited to move on up to the more difficult tasks, leaving some of the easy tasks to others so they can get involved and achieve change themselves.

Maybe you should start with issues created for first timers first-timers-only

@jasonmokk
Copy link
Contributor

@rohanKanojia My apologies, thank you for informing me about the process. I will look into the first-timers-only issues

@jasonmokk
Copy link
Contributor

jasonmokk commented May 9, 2024

Hello, may I have this issue assigned to me now?

jasonmokk added a commit to jasonmokk/jkube that referenced this issue May 9, 2024
…ethod with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
jasonmokk added a commit to jasonmokk/jkube that referenced this issue May 9, 2024
…ethod with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
@manusa manusa added this to the 1.17.0 milestone May 13, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue May 13, 2024
…nTest (3039)

Chore #3027: Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
---
Remove use of wildcard import

Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
---
Resolve dependency issues

Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants