New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore #3027: Replace AssertJ's deprecated asList() DSL method in SerializationTest #3039
Chore #3027: Replace AssertJ's deprecated asList() DSL method in SerializationTest #3039
Conversation
…ethod with asInstanceOf(InstanceOfAssertFactories.list(type.class)) Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3039 (2024-05-13T06:45:47Z) ⚙️ JKube E2E Tests (9058312634)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3039 +/- ##
=============================================
+ Coverage 59.36% 70.86% +11.50%
- Complexity 4586 5087 +501
=============================================
Files 500 490 -10
Lines 21211 19593 -1618
Branches 2830 2528 -302
=============================================
+ Hits 12591 13884 +1293
+ Misses 7370 4481 -2889
+ Partials 1250 1228 -22 ☔ View full report in Codecov by Sentry. |
jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/SerializationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
This PR replaces all instances of the deprecated
asList()
DSL method inSerializationTest
withasInstanceOf(InstanceOfAssertFactories.list(type.class))
.Resultingly,
isInstanceOf(Pod.class)
was removed from lines 85 and 104.Fixes #3027
Type of change
test, version modification, documentation, etc.)
Checklist