Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusGeneratorTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3028

Closed
2 tasks
rohanKanojia opened this issue May 8, 2024 · 1 comment · Fixed by #3049
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

.asList().singleElement().asInstanceOf(InstanceOfAssertFactories.type(Assembly.class))

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this. Once we use it, we can omit isInstanceOf(Pod.class) from line 371

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in all places in QuarkusGeneratorTest
  • .asInstanceOf() call after asList() is removed
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2024
@rohit-satya
Copy link
Contributor

@rohanKanojia Please assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
3 participants