Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCIRegistryClient : Replace deprecated org.apache.commons.io.input.CountingInputStream with org.apache.commons.io.input.BoundedInputStream #3029

Open
3 tasks
rohanKanojia opened this issue May 8, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

We're using CountingInputStream for pushing helm charts to OCI registries:

public static OCIManifestLayer from(CountingInputStream blobStream) throws IOException {

In recent releases of Apache commons io, this class has been marked as @Deprecated (see javadoc). We should replace this with the suggested alternative.

After making changes, we also need to verify that the functionality is also working as expected. For that you'll need to generate a helm chart and push it to some OCI registry (DockerHub, Quay, GitHub Container Registry etc). You can watch this demo video to get idea of workflow : 📺 Sprint 244 - Eclipse JKube: Helm push to OCI repository

Expected Behavior

CountingInputStream is replaced with suggested alternative in JavaDoc

Acceptance Criteria

  • CountingInputStream is replaced with BoundedInputStream
  • Project compiles cleanly after making changes
  • Helm Chart Push functionality is working after making changes
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2024
@rohit-satya
Copy link
Contributor

@rohanKanojia Please assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
2 participants