Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action is still in running state after it's denied #1667

Open
UVV-gh opened this issue Feb 25, 2024 · 9 comments
Open

Action is still in running state after it's denied #1667

UVV-gh opened this issue Feb 25, 2024 · 9 comments

Comments

@UVV-gh
Copy link

UVV-gh commented Feb 25, 2024

Hey there,
I'm using confirmationBase endpoint to decide whether a rollout is suitable for the device. When the client reports "denied", the action is still there and is offered on the next poll interval. What are my options here to stop it from being offered further? I see the possibility to cancel it, but that doesn't look like a proper workflow.

My expected behavior would be that action is automatically closed when it's denied. Would that be a breaking change then?

@strailov
Copy link
Contributor

Hey @UVV-gh !
Thanks for your interest in hawkBit!

Yes, indeed - the bahaviour you observe was planned to be like this.

Rejecting the action will preserve the WAIT_FOR_CONFIRMATION state. The reason for that is to give the user a chance to accept it at some point in time, if needed.
If you want to dispose of the action you could cancel it, which will change the state to cancelled and the action will be closed.

@UVV-gh
Copy link
Author

UVV-gh commented Feb 26, 2024

... If you want to dispose of the action you could cancel it, which will change the state to cancelled and the action will be closed.

Thanks for the quick response. How can I cancel it from the device side? The cancellation API seems to expect a cancellation request from the server.

@strailov
Copy link
Contributor

Which API are you using on the device side ?
If it is DDI you can use the feedback channel for cancel actions which you can find in here https://eclipse.dev/hawkbit/apis/ddi_api/

@UVV-gh
Copy link
Author

UVV-gh commented Feb 26, 2024

That's the one that I use, yes. Could you please clarify how you see the workflow. What I have right now is the following:

  • Hawkbit deployment is pushed with a request to confirm, confirmationBase endpoint is used on the client side.
  • One the client I decline the rollout and respond to confirmationBase/feedback with denied.
  • How can I also cancel the action if it was not cancelled on the server?

@strailov any advice?

@UVV-gh
Copy link
Author

UVV-gh commented Apr 9, 2024

@strailov just checking if there's any more advices from your side.

@strailov
Copy link
Contributor

Hey @UVV-gh
Nope, I think your option is the feedback channel for cancel actions
https://eclipse.dev/hawkbit/apis/ddi_api/

In other words - just report it cancelled from the device side after it was denied.

@UVV-gh
Copy link
Author

UVV-gh commented Apr 11, 2024

But that was exactly my question. If the action is not cancelled, is there actually a feedback channel for it?

@strailov
Copy link
Contributor

Ah okay.
Then what is wrong with the Feedback channel for the DeploymentBase action ? Since it is still running just report it cancelled there ?

@UVV-gh
Copy link
Author

UVV-gh commented Apr 11, 2024

According to your DDI API link above, that's not what neither DeploymentBase nor ConfirmationBase except as a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants