fix: run dumpConfig at the last ready callback

eggjs · Nov 29, 2017 · 76ff783 · 76ff783
1 parent 50efe4c
commit 76ff783
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/lib/egg.js b/lib/egg.js
@@ -55,7 +55,8 @@ class EggApplication extends EggCore {
     this.messenger = new Messenger();
 
     // dump config after ready, ensure all the modifications during start will be recorded
-    this.ready(() => this.dumpConfig());
+    // make sure dumpConfig is the last ready callback
+    this.ready(() => process.nextTick(() => this.dumpConfig()));
     this._setupTimeoutTimer();
 
     this.console.info('[egg:core] App root: %s', this.baseDir);

diff --git a/test/fixtures/apps/demo/app.js b/test/fixtures/apps/demo/app.js
@@ -0,0 +1,7 @@
+'use strict';
+
+module.exports = app => {
+  app.ready(() => {
+    app.config.tips = 'hello egg started';
+  });
+};
diff --git a/test/fixtures/apps/demo/config/config.default.js b/test/fixtures/apps/demo/config/config.default.js
@@ -18,3 +18,5 @@ exports.mysql = {
   consumerSecret: 'this is consumerSecret',
   someSecret: null,
 };
+
+exports.tips = 'hello egg';
diff --git a/test/lib/egg.test.js b/test/lib/egg.test.js
@@ -25,8 +25,10 @@ describe('test/lib/egg.test.js', () => {
       let json = require(path.join(baseDir, 'run/agent_config.json'));
       assert(/\d+\.\d+\.\d+/.test(json.plugins.onerror.version));
       assert(json.config.name === 'demo');
+      assert(json.config.tips === 'hello egg');
       json = require(path.join(baseDir, 'run/application_config.json'));
       assert(/\d+\.\d+\.\d+/.test(json.plugins.onerror.version));
+      assert(json.config.tips === 'hello egg started');
     });
 
     it('should dump config meta', () => {