Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy CI job consistently times out at 6h #1172

Closed
wdconinc opened this issue Dec 5, 2023 · 7 comments · Fixed by #1173
Closed

clang-tidy CI job consistently times out at 6h #1172

wdconinc opened this issue Dec 5, 2023 · 7 comments · Fixed by #1173

Comments

@wdconinc
Copy link
Contributor

wdconinc commented Dec 5, 2023

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (often main for latest released): main
  • Which version (or HEAD for the most recent on git): HEAD
  • Any specific OS or system where the issue occurs? CI

Steps to reproduce: (give a step by step account of how to trigger the bug)

First main pipeline where this happened: https://github.com/eic/EICrecon/actions/runs/7048345481/job/19185731729 and all since.

Expected Result: (what do you expect when you execute the steps above)

Clang-tidy should be able to complete in 6 hours.

Actual Result: (what do you get when you execute the steps above)

Times out and is canceled at 6 hours, marking the entire pipeline as failed.

This then causes all capybara reference artifacts to be stale since it downloads from the latest successful(!) pipeline on main.

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

Started with f7d793d

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

Strangely manually submitted run was fine: https://github.com/eic/EICrecon/actions/runs/7067204244

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

Strangely manually submitted run was fine

It didn't run clang-tidy since neither push not pull request event which is what clang-tidy requires.

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

Correlated in time with clang-tidy 16 upgrade.

Jobs are at different points in the output at timeout.

But seems like it hangs for a long time when enabling time stamps.

Thu, 30 Nov 2023 16:06:59 GMT
  if(!filter_surface)
Thu, 30 Nov 2023 16:06:59 GMT
                     ^
Thu, 30 Nov 2023 16:06:59 GMT
                      {
Thu, 30 Nov 2023 21:39:55 GMT
Error: The operation was canceled.

@veprbl
Copy link
Member

veprbl commented Dec 5, 2023

We could check with --enable-check-profile, but it looks like "run-clang-tidy" doesn't support passing that.

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 5, 2023

Might be llvm/llvm-project#55530.

@wdconinc wdconinc linked a pull request Dec 5, 2023 that will close this issue
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
### Briefly, what does this PR introduce?
This may fix #1172 by disabling a problematic test. Without this change,
I can reproduce the timeouts. With this change, I am not seeing the
timeouts anymore.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #1172)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants