Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade Effect Broken on Newer jQuery #87

Open
sy6502a opened this issue Aug 14, 2013 · 3 comments
Open

Fade Effect Broken on Newer jQuery #87

sy6502a opened this issue Aug 14, 2013 · 3 comments

Comments

@sy6502a
Copy link

sy6502a commented Aug 14, 2013

When using this plugin with newer versions of jQuery like 1.9, the fade effect option will stop the rotation of the images on the last image.

It took me quite a while to figure this out. Hopefully the code can be updated, or even the main page changed from required files (1.3+) to (1.3-1.8) or something. But otherwise to the author, great plugin, thanks for sharing!

It turns out that "$.browser.msie" is removed in jQuery 1.9 and later.

I'm no jQuery expert, but here are 2 solutions to this issue that worked for me.

Add the migration plugin to your script that brings back the functionality :
http://code.jquery.com/jquery-migrate-1.2.1.js

Or replace in jShowOff.js:

$.browser.msie

with

navigator.userAgent.match(/msie/i)

@ericnims
Copy link

Worked like a champ. Need to replace it in the .min file too. You saved me a TON of time.

Thanks!!!

@ibprogrammin
Copy link

Noice! Thanks for this!

@timriker
Copy link

The navigator.userAgent.match(/msie/i) fix worked for me. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants