Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ComposeC #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ericson2314
Copy link

Fixes #83

Ericson2314 added a commit to obsidiansystems/constraints-extras that referenced this pull request Jan 29, 2019
Blocked on ekmett/constraints#84 exposing
`ComposeC`.
@RyanGlScott
Copy link
Collaborator

Looks sensible to me. It looks like the build is failing on older GHCs due to UndecidableInstances not being enabled—can you add that?

Also, would you mind mentioning this in the CHANGELOG.md? Thanks!

@Ericson2314
Copy link
Author

Yeah busy day, but I'll get to those two things.

@Ericson2314
Copy link
Author

Ericson2314 commented Jan 29, 2019

Related to this, I also have use for a FlipC: https://github.com/obsidiansystems/constraints-extras/pull/4/files#diff-5ed8f2541b375e8ecca027c7d55495bbR38 Mind if I add that too? And if so, what module?

@RyanGlScott
Copy link
Collaborator

Related to this, I also have use for a FlipC: https://github.com/obsidiansystems/constraints-extras/pull/4/files#diff-5ed8f2541b375e8ecca027c7d55495bbR38 Mind if I add that too? And if so, what module?

I'm not technically the maintainer of this library (@ekmett is), so I can't really speak as to whether constraints is an appropriate place for FlipC or not. Adding ComposeC seems like a no-brainer, since we're just exposing functionality that's already there, but FlipC is a different beast entirely. (I'm only acting conservatively here since @ekmett has expressed reservations in the past about adding generic Constraint type combinators, such as in #47 (comment)).

Regardless, it might be best to leave that for a separate PR.

@Ericson2314
Copy link
Author

Makes sense; no problem.

@Ericson2314
Copy link
Author

Ericson2314 commented Jan 29, 2019

Oh but the second think proposed in the thread you linked is Compose exactly; and it also falls under the "avoid higher kinds" dictum.

@RyanGlScott
Copy link
Collaborator

I discovered recently that sop-core also exposes a Compose class here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ComposeC
2 participants