Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragile build failure(s) using --flag=-tagged in dependencies #25

Open
recursion-ninja opened this issue Apr 12, 2024 · 2 comments
Open

Comments

@recursion-ninja
Copy link
Contributor

I attempted to build the keys-3.12.3 package with the following cabal.project file:

constraints:
     semigroupoids -tagged,

This results in a compilation error during the package build process:

Building library for keys-3.12.3..
[1 of 1] Compiling Data.Key

src/Data/Key.hs:823:10: error: [GHC-39999]
    • No instance for ‘Traversable1 (Tagged a)’
        arising from the superclasses of an instance declaration
    • In the instance declaration for ‘TraversableWithKey1 (Tagged a)’
    |
823 | instance TraversableWithKey1 (Tagged a) where

Perhaps the keys package should add flags to mirror those in semigroupoids in order to allow a smaller dependency footprint. The containers flag can probably be elided, leaving the following:

  • flag comonad
  • flag contravariant
  • flag distributive
  • flag tagged
  • flag unordered-containers

I know that this package is "pseudo-depreciated," but there are enough reverse dependencies (7809 indirect) that I think this usability enhancement would be worth the modest investment.

@RyanGlScott
Copy link
Collaborator

I'd accept a PR that does this, but I doubt that I will have the energy to do this myself.

@recursion-ninja
Copy link
Contributor Author

I'd accept a PR that does this, but I doubt that I will have the energy to do this myself.

No problem, see #26 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants