Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Year of scrobble is never present in display #233

Closed
Nixinova opened this issue May 20, 2024 · 1 comment · Fixed by #234
Closed

Year of scrobble is never present in display #233

Nixinova opened this issue May 20, 2024 · 1 comment · Fixed by #234

Comments

@Nixinova
Copy link
Contributor

Describe the bug
The year of scrobbles is never present. This can be misleading making you think you'll be able to scrobble a track even if its years old.

Expected behavior
Year is included in date if <= last year.

Screenshots

image
2005
image

https://www.last.fm/user/test
@Nixinova Nixinova changed the title Year is not present Year of scrobble is never present in display May 20, 2024
@Nixinova
Copy link
Contributor Author

OpenWebScrobbler/src/components/ScrobbleItem.tsx

Lines 168 to 172 in 196c397

if (!isToday(new Date(scrobble.timestamp))) {
timestampFormat = `${settings?.use12Hours ? 'M/d' : 'd/MM'} `;
}
timestampFormat += settings?.use12Hours ? 'hh:mm a' : 'HH:mm';
theTimestamp = format(new Date(scrobble.timestamp), timestampFormat);

Nixinova added a commit to Nixinova/fork_OpenWebScrobbler that referenced this issue May 20, 2024
@Nixinova
Show year in timestamp if older than this year
5472b97 
Fixes elamperti#233
@Nixinova Nixinova mentioned this issue May 20, 2024
Merged
elamperti pushed a commit that referenced this issue May 27, 2024
@Nixinova
Show year in timestamp if older than this year (#234)
34e068e 
Fixes #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show year in timestamp if older than this year Nixinova/fork_OpenWebScrobbler
1 participant
@Nixinova