Make the project compilable when it's added as a git submodule #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous gitBranch() function only search '$rootDir/.git/HEAD' file. But, when the project is added as a git sub module, the '$rootDir/.git' is a file, not a directory. The file stores the module git repository directory. So the change is to help finding the submodule local git repository. Signed-off-by: Zhang Wei <weiz@lambdacloud.com>
|
@wezhang Can you please sign the CLA in order to merge this PR? Thanks, |
|
Without an update and the CLA not signed, I'm afraid I have to close the PR without merging it. Sorry... |
|
Sorry, I just got the comments... preparing CLA now. |
|
Thanks for your contribution. Your PR was cherry-picked against 2.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous gitBranch() function only search '$rootDir/.git/HEAD' file.
But, when the project is added as a git sub module, the '$rootDir/.git'
is a file, not a directory. The file stores the module git repository
directory. So the change is to help finding the submodule local git
repository.
Signed-off-by: Zhang Wei weiz@lambdacloud.com