Skip to content

Conversation

randallwhitman
Copy link

Add an overload with all the three parameters available with
EsSpark.esRDD(..., resource, query, cfg).
Likewise for esJsonRDD.

This change makes SparkContextFunctions.esRDD more consistent with SQLContextFunctions.esDF which already has an overload taking all 3 parameters.

Implements #592.

Add an overload with all three parameters available with
EsSpark.esRDD(..., resource, query, cfg).
Likewise for esJsonRDD.
@costin
Copy link
Member

costin commented Nov 9, 2015

@randallwhitman I was about to push a commit fixing the issue. Can you please sign the CLA so I can use your PR instead?

Thanks,

@randallwhitman
Copy link
Author

Probably, but if you already have a commit prepared, wouldn't that be easier than processing a CLA?

@costin
Copy link
Member

costin commented Nov 9, 2015

The CLA should be processed automatically. As for the commit, you already went through the process of providing a fix, plus reporting the bug and I think it would be a good way to recognize your efforts by including your work in the project.
Let me know what option you prefer.

Cheers,

@randallwhitman
Copy link
Author

Thanks Costin - that makes sense, and I appreciate it.

Because I made the patch while working for my employer on integration with Elasticsearch, the CLA would have to go through some corporate process.

In this case it may be in our mutual interest to close this PR without merging, and use your independent commit.

@costin costin closed this in a97fa9f Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants