Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Options - field include and field include as array #671

Closed
ogirardot opened this issue Jan 26, 2016 · 1 comment
Closed

Configuration Options - field include and field include as array #671

ogirardot opened this issue Jan 26, 2016 · 1 comment

Comments

@ogirardot
Copy link

There seems to be a few things off when looking at the ConfigurationOptions :
https://github.com/elastic/elasticsearch-hadoop/blob/master/mr/src/main/java/org/elasticsearch/hadoop/cfg/ConfigurationOptions.java#L198
and
https://github.com/elastic/elasticsearch-hadoop/blob/master/mr/src/main/java/org/elasticsearch/hadoop/cfg/ConfigurationOptions.java#L201
seems to be the opposite ?
And https://github.com/elastic/elasticsearch-hadoop/blob/master/spark/sql-12/src/main/scala/org/elasticsearch/spark/sql/SchemaUtils.scala#L60 is not using the ConfigurationOptions.

I'd be glad to submit a PR but first I'd like to check if it's supposed to be this complicated ?

Regards,

Olivier.

@costin
Copy link
Member

costin commented Jan 26, 2016

Ooops. Thanks @ogirardot - you are right. Interestingly enough most of the tests were passing due to the usage of constants vs inlined strings.
The SQL-12 module is in the process of being updated - thanks for pointing out this mistake, I'll beef out the test suite further.

@costin costin added the bug label Jan 26, 2016
@costin costin closed this as completed in 88f811c Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants