Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname resolving should be configurable #731

Closed
1 of 2 tasks
costin opened this issue Apr 2, 2016 · 0 comments
Closed
1 of 2 tasks

Hostname resolving should be configurable #731

costin opened this issue Apr 2, 2016 · 0 comments

Comments

@costin
Copy link
Member

costin commented Apr 2, 2016

  • Bug report. If you’ve found a bug, please provide a code snippet or test to reproduce it below.
    The easier it is to track down the bug, the faster it is solved.
  • Feature Request. Start by telling us what problem you’re trying to solve.
    Often a solution already exists! Don’t send pull requests to implement new features without
    first getting our support. Sometimes we leave features out on purpose to keep the project small.

Issue description

While hostname resolving makes sense for direct-node connections, in wan mode not so much and in fact can prevent connections from happening since the provider might expect the hostname and not the IP.
As such, the resolving should be configurable and likely, in case of wan mode, disabled unless configured otherwise.

@costin costin closed this as completed in 5875091 Apr 3, 2016
costin added a commit that referenced this issue Apr 8, 2016
Introduce es.nodes.resolve.hostname property
By default turned to true, false if wan is enabled

close #731

(cherry picked from commit 5875091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant