Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: ES-Hadoop on Spark 2.0 #759

Closed

Conversation

jamesblau
Copy link

This pull request builds elasticsearch-spark with Spark 2.0.0-SNAPSHOT, also using Scala 2.11 by default. Hopefully it would be ready for the Spark 2.0 release.

There are currently errors when building with Scala 2.10 (running ./gradlew -Pscala=210): it doesn't seem to be using the proper Spark version.

A sub-project elasticsearch-spark-1.3 replaces elasticsearch-spark-1.2. I also dropped the allProjects.configurations.all.resolutionStrategy block from build.gradle, which had seemed to cause the integrationTest task to hang indefinitely for this sub-project, although I don't know why.

(CLA pending, but will be approved before this is needed.)

This pull request builds elasticsearch-spark with Spark 2.0.0-SNAPSHOT, also using Scala 2.11 by default. Hopefully it would be ready for the Spark 2.0 release.

There are currently errors when building with Scala 2.10 (running ./gradlew -Pscala=210): it doesn't seem to be using the proper Spark version.

A sub-project elasticsearch-spark-1.3 replaces elasticsearch-spark-1.2. I also dropped the allProjects.configurations.all.resolutionStrategy block from build.gradle, which had seemed to cause the integrationTest task to hang indefinitely for this sub-project, although I don't know why.
@costin
Copy link
Member

costin commented May 11, 2016

@jamesblau I appreciate the PR but what is it its purpose? Spark 2.0 is currently SNAPSHOT so why build against it?
Also since the PR has errors, why raise it in the first place? Why not wait for Spark 2.0?

Fwiw, there's already a spark 2.0 branch [1] that I've created some time ago; I haven't kept it up to date or pushed it since things are too much in flux.

[1] https://github.com/costin/elasticsearch-hadoop/tree/spark20

@jurriaan
Copy link

@jamesblau Thanks a lot, this is quite useful! Now running against a custom build using your changes so I can use Spark 2.0.

@jmritz
Copy link

jmritz commented Jul 28, 2016

@costin Is there any status on Spark 2.0.0 integration?

@costin
Copy link
Member

costin commented Jul 28, 2016

Yes, it should land in master later today. We're currently testing the PR from @jimferenczi which increases the parallelism as well (see the master).

@costin
Copy link
Member

costin commented Jul 28, 2016

Since support for Spark 2.0 is close to be added in master and this PR is old, I'm closing it down.
Thanks for the contribution and next time, please consider signing the CLA.

Cheer,s

@costin costin closed this Jul 28, 2016
@costin
Copy link
Member

costin commented Jul 28, 2016

@jmritz Spark 2.0 just hit master. See #647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants