Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when displaying help information on elasticsearch deprecation log is misleading about its location #117

Open
majormoses opened this issue Dec 8, 2017 · 1 comment

Comments

@majormoses
Copy link

majormoses commented Dec 8, 2017

This makes the assumption that the cluster name has not been changed from the default of elasticsearch. I had to spend some time convincing a developer and had to go to the source to confirm this is no indication of the actual filename and is just the default location.

<p>
Deprecation logs can be found in the logs directory, in the
file named <code>elasticsearch_deprecation.log</code>
</p>

I think we should either enhance the verbiage to say something like this:

Deprecation logs can be found in the logs directory, in the file named `$CLUSTERNAME_deprecation.log`

Or even better would be to actually just return the value from the es query as you already have this info anyways. For example:

$ curl -s -S $REDACTED:9200/_cluster/state | jq .cluster_name
"es-app"
$ curl -s -S $REDACTED:9200 | jq .cluster_name
"es-app"

This could be javascriptified I am sure but I just wanted to see what peoples thoughts were on this before spending time hacking javascript which I don't really touch front end code so I am sure it would horrify most.

@majormoses majormoses changed the title when displaying help information on elasticsearch deprecation log is misleading when displaying help information on elasticsearch deprecation log is misleading about its location Dec 8, 2017
@clintongormley
Copy link
Contributor

Good point @majormoses. That said, this migration tool is unlikely to see another release now, so it is probably not worth fixing at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants