Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Contributing guide is not updated or confusing #1248

Open
imdhemy opened this issue Aug 23, 2022 · 1 comment
Open

[Documentation] Contributing guide is not updated or confusing #1248

imdhemy opened this issue Aug 23, 2022 · 1 comment
Assignees

Comments

@imdhemy
Copy link

imdhemy commented Aug 23, 2022

Summary of problem or feature request

I followed the contributing guide. When I tried to run the RestSpecRunner I got the following error:

ERROR: Host https://localhost:9200 is offline

After some research I found that the RestSpecRunner is not using the environment variable ES_TEST_HOST, but
instead it is using the ELASTICSEARCH_URL here.

When I set the ELASTICSEARCH_URL, the RestSpecRunner works fine and the unit tests are passing.

I did the same with integration tests, all of them are passing except the MlTest which requires a platinum license if I'm not mistaken.

Questions

  • Should the documentation be updated to refer to ELASTICSEARCH_URL?
  • Should all integration tests pass on local machines? If yes, Is there any guide for that?
@ezimuel
Copy link
Contributor

ezimuel commented Aug 24, 2022

@imdhemy thanks for opening this issue. I'll fix the documentation asap.

@ezimuel ezimuel self-assigned this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants