Return an HTTP error code when a suggest request failed instead of 200

[obourgain]

The _suggest API always returns 200 regardless of the call being successful or not.
This PR sets the http status in a way similar to the SearchResponse https://github.com/elastic/elasticsearch/blob/master/src/main/java/org/elasticsearch/action/search/SearchResponse.java#L71

[s1monw]

I like this change, can we instead of duplicating the functionality add a static method to RestStatus that looks like this public static RestStatus status(int successfulShards, int totalShards, ShardOperationFailedException... failures) and use it in both places?

[s1monw]

@areek I assigned this to you, can you take care of it?

[obourgain]

With a quick search, it seems that there are some other place that have a similar loop over failures and could also use a static method.

[s1monw]

With a quick search, it seems that there are some other place that have a similar loop over failures and could also use a static method.

cool, if you could update your PR that would be awesome!

[obourgain]

I updated it with the status() method on RestStatus as suggested.

CountResponse, RestSuggestAction, SearchResponse and SnapshotInfo will use this method.

For the record, there are also loops over failures in SearchPhaseExecutionException and DeleteByQueryResponse but they are quite different so I didn't try to modify those.

[areek]

@obourgain Thanks for the the PR! This looks good to me. I will merge this in early next week

[s1monw]

@areek it's pretty low risk and is a bug, should we pull it for 1.5?

[areek]

@s1monw makes sense, will merge it in

[areek]

Merged to 1.5 (47d0ae6),
1.x (35fcdf5) and master (deade2e)