Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEO] GeoPointFieldMapper.validate_* overwritten on merge #10164

Closed
nknize opened this issue Mar 19, 2015 · 0 comments · Fixed by #10165
Closed

[GEO] GeoPointFieldMapper.validate_* overwritten on merge #10164

nknize opened this issue Mar 19, 2015 · 0 comments · Fixed by #10165
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug good first issue low hanging fruit v1.5.1 v2.0.0-beta1

Comments

@nknize
Copy link
Contributor

nknize commented Mar 19, 2015

During a merge the validate_lat and validate_lon parameters for the geo_point field mapper are being overwritten by the incoming field mappings. This can cause problems during search where invalid geo_points (which were formerly acceptable) are no longer acceptable causing exceptions when parsing the (now invalid) geo points.
@nknize nknize added >bug v2.0.0-beta1 good first issue low hanging fruit v1.5.0 :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Mar 19, 2015
@nknize nknize mentioned this issue Mar 19, 2015
Merged
@martijnvg martijnvg added v1.5.1 and removed v1.5.0 labels Mar 23, 2015
nknize added a commit to nknize/elasticsearch that referenced this issue Mar 24, 2015
@nknize
[GEO] Fix validate_* merge policy for GeoPointFieldMapper
e43f3a9 
Fail merge if validate_lat or validate_lon values are not equal. This will prevent inconsistencies between geo_points in a merged index, and parse exceptions for bounding_box and distance filters.

Also merged separate GeoPoint test classes into a single GeoPointFieldMapperTest to be consistent with GeoShapeFieldMapperTests.

closes elastic#10164
nknize added a commit that referenced this issue Mar 24, 2015
@nknize
[GEO] Fix validate_* merge policy for GeoPointFieldMapper
7b6364d 
Fail merge if validate_lat or validate_lon values are not equal. This will prevent inconsistencies between geo_points in a merged index, and parse exceptions for bounding_box and distance filters.

Also merged separate GeoPoint test classes into a single GeoPointFieldMapperTest to be consistent with GeoShapeFieldMapperTests.

closes #10164
nknize added a commit that referenced this issue Mar 24, 2015
@nknize
[GEO] Fix validate_* merge policy for GeoPointFieldMapper
b140e9f 
Fail merge if validate_lat or validate_lon values are not equal. This will prevent inconsistencies between geo_points in a merged index, and parse exceptions for bounding_box and distance filters.

Also merged separate GeoPoint test classes into a single GeoPointFieldMapperTest to be consistent with GeoShapeFieldMapperTests.

closes #10164
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@nknize
[GEO] Fix validate_* merge policy for GeoPointFieldMapper
940086c 
Fail merge if validate_lat or validate_lon values are not equal. This will prevent inconsistencies between geo_points in a merged index, and parse exceptions for bounding_box and distance filters.

Also merged separate GeoPoint test classes into a single GeoPointFieldMapperTest to be consistent with GeoShapeFieldMapperTests.

closes elastic#10164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug good first issue low hanging fruit v1.5.1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix validate_* merge policy for GeoPointFieldMapper nknize/elasticsearch
2 participants
@martijnvg @nknize