Add before/afterIndexShardDelete callbacks to index lifecycle #10173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows code to be executed before or after a shards content is deleted from disk. This is only executed if the shard owns the content ie. on a shard file system only a primary shard will execute these operations.
s1monw
force-pushed
the
shard_delete_callback
branch
from
ac031dd
to
d9be606
Compare
| * @param shardId The shard id | ||
| * @param indexSettings the shards index settings | ||
| */ | ||
| public void afterIndexShardDeleted(ShardId shardId, Settings indexSettings) { |
There was a problem hiding this comment.
Can you annotate this and the previous indexSettings with @IndexSettings? (I still wish we had separate classes, but it makes it easier to identify in the event this gets renamed to something non-specific).
|
LGTM, left one comment. Also, I think this needs to go into 1.5.0? |
|
updated... will push soon |
clintongormley
added
:Distributed/Store
clintongormley
changed the title
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows code to be executed before or after a shards contentvis deleted from disk. This is only executed if the shard owns the content ie. on a shard file system only a primary shard will execute these operations.