Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks for preventing NPEs in MetaData#concreteIndices #10339

Closed
cbuescher opened this issue Mar 31, 2015 · 0 comments
Closed

Checks for preventing NPEs in MetaData#concreteIndices #10339

cbuescher opened this issue Mar 31, 2015 · 0 comments
Assignees
@cbuescher
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement v1.6.0 v2.0.0-beta1

Comments

@cbuescher
Copy link
Member

This is a follow issue pulled out of #10148. The current implementation of MetaData.concreteIndices() leaves some edge cases where NPEs can occurr. This can happen when wildcard expansion is switched off for both open and closed indices in the IndicesOptions and the method is calles with nullor empty list for the aliasOrIndices argument.

This PR adds a check and randomized tests for this method.
@cbuescher cbuescher added >enhancement v2.0.0-beta1 :Data Management/Indices APIs APIs to create and manage indices and templates v1.6.0 labels Mar 31, 2015
@cbuescher cbuescher self-assigned this Mar 31, 2015
cbuescher pushed a commit that referenced this issue Apr 1, 2015
Core: Remove potential NPE while resolving concrete indices from Meta…
c907dc6 
…Data

Prevents a current edge case resolving concrete aliases or index names in cluster MetaData
that could potentialy lead to NullPointerException when the IndicesOptions don't allow
wildcard expansion and the method is called with aliasesOrIndices argument null or emtpy list.
This change adds a check for that and introduces randomized test that catches this.

Closes #10342
Closes #10339
@cbuescher cbuescher mentioned this issue Apr 1, 2015
Closed
@cbuescher cbuescher mentioned this issue May 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement v1.6.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check to MetaData#concreteIndices to prevent NPE cbuescher/elasticsearch
1 participant
@cbuescher