Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search_quote_analyzer always added to mapping when position_offset_gap is specified #10357

Closed
jtibshirani opened this issue Mar 31, 2015 · 0 comments
Closed

search_quote_analyzer always added to mapping when position_offset_gap is specified #10357

jtibshirani opened this issue Mar 31, 2015 · 0 comments
Assignees
@rjernst
Labels
>bug :Search/Mapping Index mappings, including merging and defining field types

Comments

@jtibshirani
Copy link
Contributor

If position_offset_gap is specified in a field's mapping, search_quote_analyzer is always added, even if no analyzer was specified:

https://gist.github.com/jtibshirani/f4acab68e7e505fb1778

For consistency, search_quote_analyzer should only be in the mapping if it has been specified and differs from search_analyzer.
@jtibshirani jtibshirani mentioned this issue Apr 1, 2015
Closed
@javanna javanna added >bug v1.6.0 v2.0.0-beta1 v1.5.1 :Search/Mapping Index mappings, including merging and defining field types labels Apr 2, 2015
@javanna javanna self-assigned this Apr 2, 2015
@javanna javanna assigned rjernst and unassigned javanna Apr 2, 2015
rjernst pushed a commit that referenced this issue Apr 17, 2015
@jtibshirani @rjernst
Mappings: Fixed an equality check in StringFieldMapper.
c8f85d0 
The check was ineffective and was causing search_quote_analyzer to be added to the mapping unnecessarily.

Closes #10357
closes #10359
rjernst pushed a commit that referenced this issue Apr 17, 2015
@jtibshirani @rjernst
Mappings: Fixed an equality check in StringFieldMapper.
9d5662c 
The check was ineffective and was causing search_quote_analyzer to be added to the mapping unnecessarily.

Closes #10357
closes #10359
brwe pushed a commit to brwe/elasticsearch that referenced this issue Apr 18, 2015
@jtibshirani @brwe
Mappings: Fixed an equality check in StringFieldMapper.
bff2635 
The check was ineffective and was causing search_quote_analyzer to be added to the mapping unnecessarily.

Closes elastic#10357
closes elastic#10359
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@jtibshirani @rjernst
Mappings: Fixed an equality check in StringFieldMapper.
aa55f22 
The check was ineffective and was causing search_quote_analyzer to be added to the mapping unnecessarily.

Closes elastic#10357
closes elastic#10359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
>bug :Search/Mapping Index mappings, including merging and defining field types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed an equality check in StringFieldMapper.
3 participants
@rjernst @javanna @jtibshirani